#pr-reviews - June 2025

11 messages

Pull Request Reviews for Cloud Posse Projects

Tyrone Meijn
Tyrone Meijnover 1 year ago
A PR is open for quite a while which updates the AMI for the bastion server: https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/247. It is now in conflict. Can this be resolved or should I open another MR with these changes?
Pablo Paez
Pablo Paezover 1 year ago
Hi 👋🏻
I want to enhance the customization options for the assume role specified by terraform-aws-iam-role. To achieve this, I've prepared two PRs following different approaches:
• Breaking change: https://github.com/cloudposse/terraform-aws-iam-role/pull/85
• Backwards compatible: https://github.com/cloudposse/terraform-aws-iam-role/pull/86
I would appreciate your input.
Jan Costandius
Jan Costandiusover 1 year ago
I was advised to forward this to this channel. This PR addresses some of the missing features of GuardDuty that is not present in the existing module.
Jan Costandius
Jan Costandiusover 1 year ago
Michael
Michaelover 1 year ago
Here's a PR for adding basic tests for the aws-kms component: https://github.com/cloudposse-terraform-components/aws-kms/pull/24
mika_l
mika_lover 1 year ago
A single character fix for the simple (non atmos) tf backend I made in january: https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/185 would be great to get it out 🙂🙏
Nitin
Nitinover 1 year ago
Urgent: Fix Compatibility issue with Terraform AWS Provider v6.0.0
https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/261
Michael
Michaelover 1 year ago
Amazon Elastic Graphics died on 8 Jan 2024, and the AWS provider yanked the elastic_gpu_specifications parameters in v6.0.0. This PR removes the deprecated block: https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/154
Quixotical
Quixoticalover 1 year ago(edited)
hey everyone! This is a fix for compatibility issue with Terraform AWS Provider v6.0.0 for aws-dms-endpoint module
https://github.com/cloudposse/terraform-aws-dms/pull/41

This is my first contribution, so if there's anything I should change, don't hesitate to let me know! 🙂
Ricky Fontaine
Ricky Fontaineover 1 year ago
Hey! I've raised a PR to add the AL2023_ARM_64_NVIDIA ami type to the terraform-aws-eks-node-group module. https://github.com/cloudposse/terraform-aws-eks-node-group/pull/216
This AMI type was first released in April. Let me know if there's anything you need 🙂