pr-reviews
2993,531
Pull Request Reviews for Cloud Posse Projects
Nitin J1 day ago
Hi team 👋 Could someone take a look at these, please?
1. Node 24 runtime for install-gh-releases
github.com/cloudposse-github-actions/install-gh-releases/pull/35
• Changes the action runtime from node20 to node24, updates .node-version and engines, and pins the CI actions to Node 24 releases. The action code is unchanged.
• github-action-atmos-terraform-apply uses this action, so every apply run logs the "Node.js 20 is deprecated … forced to run on Node.js 24" warning.
2. aws-argocd-github-repo: deploy keys hardcoded to RSA-2048, which GitHub now rejects
github.com/cloudposse-terraform-components/aws-argocd-github-repo/issues/64
• tls_private_key uses rsa_bits = "2048", so adding a new environment fails with 422 key is too short … at least 3072 bits. Affects v2.1.1 and v2.2.0 (latest).
• Suggested fix: change it to rsa_bits = 4096 (or ED25519), or make it a variable. Happy to raise the PR if that's the preferred approach.
Thanks! 🙏
1. Node 24 runtime for install-gh-releases
github.com/cloudposse-github-actions/install-gh-releases/pull/35
• Changes the action runtime from node20 to node24, updates .node-version and engines, and pins the CI actions to Node 24 releases. The action code is unchanged.
• github-action-atmos-terraform-apply uses this action, so every apply run logs the "Node.js 20 is deprecated … forced to run on Node.js 24" warning.
2. aws-argocd-github-repo: deploy keys hardcoded to RSA-2048, which GitHub now rejects
github.com/cloudposse-terraform-components/aws-argocd-github-repo/issues/64
• tls_private_key uses rsa_bits = "2048", so adding a new environment fails with 422 key is too short … at least 3072 bits. Affects v2.1.1 and v2.2.0 (latest).
• Suggested fix: change it to rsa_bits = 4096 (or ED25519), or make it a variable. Happy to raise the PR if that's the preferred approach.
Thanks! 🙏
Marat Bakeev2 days ago
Hi team, I have a proposition to patch policy for security hub -
github.com/cloudposse-terraform-components/aws-security-hub/pull/61
github.com/cloudposse-terraform-components/aws-security-hub/pull/61
Without a condition, the delegated administrator can callDisablePolicyTypefor any policy type, includingSERVICE_CONTROL_POLICY
Michael4 days ago
If anyone has a chance, this fixes some deprecated syntax, wires a missing parameter, and fixes the vpc tests:
github.com/cloudposse/terraform-aws-vpc/pull/171
github.com/cloudposse/terraform-aws-vpc/pull/171
Ivan Pinatti5 days ago
Could I please get a review/approval for this PR?
• github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/77 -- adds an
• github.com/cloudposse-terraform-components/aws-aurora-postgres-resources/pull/77 -- adds an
additional_extensions option to CloudPosse's aws-aurora-postgres-resources component, so Postgres extensions like pg_stat_statements (needed for Datadog Database Monitoring) are created in Terraform instead of by handMarat Bakeev6 days ago
Hi team, some PRs from me, please have a look when possible:
github.com/cloudposse/terraform-aws-route53-resolver-dns-firewall/pull/34 - Add an optional
github.com/cloudposse-terraform-components/aws-route53-resolver-dns-firewall/pull/53 - upgrade the component for dns firewall to use that optional attribute
and an option for karpenter node pools to allow nested virtualization
github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/75
github.com/cloudposse/terraform-aws-route53-resolver-dns-firewall/pull/34 - Add an optional
firewall_domain_redirection_action attributegithub.com/cloudposse-terraform-components/aws-route53-resolver-dns-firewall/pull/53 - upgrade the component for dns firewall to use that optional attribute
and an option for karpenter node pools to allow nested virtualization
github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/75
PePe Amengual8 days ago(edited)
also this https://github.com/cloudposse-terraform-components/aws-alb/pull/80 and https://github.com/cloudposse-terraform-components/aws-alb/pull/81 and https://github.com/cloudposse-terraform-components/aws-alb/pull/82
PePe Amengual12 days ago
also I have this https://github.com/cloudposse-terraform-components/aws-ipam/pull/49
PePe Amengual12 days ago
Ivan Pinatti18 days ago
Hello, could I please get a review/approval on these?
• github.com/cloudposse-terraform-components/aws-ssosync/pull/53
• github.com/cloudposse/terraform-aws-datadog-integration/pull/86
• github.com/cloudposse-terraform-components/aws-ssosync/pull/53
• github.com/cloudposse/terraform-aws-datadog-integration/pull/86
Ivan Pinatti20 days ago
And a small bugfix in the other component
• github.com/cloudposse/terraform-aws-datadog-integration/pull/85
• github.com/cloudposse/terraform-aws-datadog-integration/pull/85
Ivan Pinatti20 days ago
It is me again.. Not Mario!
I have two small PRs related to the SSO component, could I please get a review/approval?
• github.com/cloudposse-terraform-components/aws-ssosync/pull/52
• github.com/cloudposse-terraform-components/aws-ssosync/pull/51
I have two small PRs related to the SSO component, could I please get a review/approval?
• github.com/cloudposse-terraform-components/aws-ssosync/pull/52
• github.com/cloudposse-terraform-components/aws-ssosync/pull/51
Ivan Pinatti20 days ago(edited)
Hello, could I please get a full review on these two @Igor Rodionov? These are the two new repos for
• github.com/cloudposse/terraform-aws-codeartifact/pull/1
• github.com/cloudposse-terraform-components/aws-codeartifact/pull/3
CodeArtifact that I was talking with Erik recently.• github.com/cloudposse/terraform-aws-codeartifact/pull/1
• github.com/cloudposse-terraform-components/aws-codeartifact/pull/3
Abdulwahab Abdusomad Olayiwola23 days ago
Hello, Can I get some reviews please?
1. github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/283
2. github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/284
3. github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/285
1. github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/283
2. github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/284
3. github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/285
Ivan Pinatti28 days ago
The release is stuck on this repo, could someone please unstuck it? ☝️
Ivan Pinatti29 days ago
New week and new PRs coming. Could you please review?
• github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/104 -- it lets the component create and wire up the CloudWatch log groups for Redis slow and engine logs instead of expecting them to already exist, and exposes
• github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/104 -- it lets the component create and wire up the CloudWatch log groups for Redis slow and engine logs instead of expecting them to already exist, and exposes
cluster_mode_enabled rather than always deriving it from num_shards.Ivan Pinattiabout 1 month ago
Happy Friday everyone!! One last PR this week por favor;
• github.com/cloudposse-terraform-components/aws-waf/pull/87 -- It makes
• github.com/cloudposse-terraform-components/aws-waf/pull/87 -- It makes
byte_match_statement optional in rate-based scope-down statements and adds or_byte_match_statements, so one rate limit can cover several paths against a single counter, matching what module v1.18.1 already acceptsIvan Pinattiabout 1 month ago
Hello, could I get a review please?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/123 - Adds
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/123 - Adds
query_exclusions so an archive can drop a class of logs, like health checks, without restating the whole query, and applies it to the catchall archive too.Ivan Pinattiabout 1 month ago(edited)
Hello, could I get a review on this PR please?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.
Ivan Pinattiabout 1 month ago
Hey, could I please get a review on this one?
• github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
• github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
Ivan Pinattiabout 1 month ago
Could I get a review please?
• github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks
• github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks
aws-datadog-monitor, where terraform init and terraform validate both fail on main todayMichaelabout 1 month ago
If anyone has a chance to review, this adds some SSM functions to the test-helpers package. When we build an AMI with Packer, we use Terraform, Terratest, and SSM to run host checks to ensure it's configured as we intend. Contributing these back to the community for other's use could be beneficial for reusability
github.com/cloudposse/test-helpers/pull/99
github.com/cloudposse/test-helpers/pull/99
PePe Amengualabout 1 month ago
this is ready for review https://github.com/cloudposse/terraform-aws-ipam/pull/3
PePe Amengualabout 1 month ago(edited)
any reason why the IPAM component used https://github.com/aws-ia/terraform-aws-ipam instead of a cloudposse managed module? last release of the AWS maintained module is a year old, are you guys open on creating a cloudposse owned module? ( I have cycles and interest)
Ivan Pinattiabout 1 month ago
Please could I get a review on this PR?
• github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
• github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
Ivan Pinattiabout 2 months ago
Happy Friday! The last PR for this week, could I please get a review?
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including
cluster_parameter_group_family which RA3/RG clusters needIvan Pinattiabout 2 months ago
Could I also get a review on this PR please?
• github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
• github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
Ivan Pinattiabout 2 months ago(edited)
Could I please get an approval review on these two Renovate PRs? Both are green and just blocked on
• github.com/cloudposse-terraform-components/aws-redshift/pull/55
• github.com/cloudposse-terraform-components/aws-redshift/pull/46
REVIEW_REQUIRED.• github.com/cloudposse-terraform-components/aws-redshift/pull/55
• github.com/cloudposse-terraform-components/aws-redshift/pull/46
PePe Amengualabout 2 months ago
If I could gets some eyes on https://github.com/cloudposse-terraform-components/aws-config/pull/69
Ivan Pinattiabout 2 months ago
Please could I get a review on this PR?
• github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard
• github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard
domain_nameBen Smith (Benbentwo)about 2 months ago
One tiny PR for EKS Cluster module github.com/cloudposse/terraform-aws-eks-cluster/pull/266
Ben Smith (Benbentwo)about 2 months ago
Small pr for EKS Cluster github.com/cloudposse-terraform-components/aws-eks-cluster/pull/95
Ivan Pinattiabout 2 months ago(edited)
Could I please get a review on these 4 PRs?
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period
Two small things that would help:
• The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period
Two small things that would help:
• The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
dmitrijnabout 2 months ago
hello, please review github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/164
Ivan Pinattiabout 2 months ago
Another PR, unrelated with the previous ones. Could I please also get a review?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
◦ Changes the archive bucket lifecycle default from
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
◦ Changes the archive bucket lifecycle default from
GLACIER to GLACIER_IR. Datadog can't read GLACIER for rehydration or Archive Search, so on the default config the archive silently becomes unreadable a year after the first object lands.Ivan Pinattiabout 2 months ago
One more PR, this is a bug in the ssm path, easy review.
• github.com/cloudposse-terraform-components/aws-redshift/pull/51
• github.com/cloudposse-terraform-components/aws-redshift/pull/51
Ivan Pinattiabout 2 months ago(edited)
Could I please get a review on these 3 PRs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/50
◦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
• github.com/cloudposse-terraform-components/aws-redshift/pull/49
◦ Removes an output that no longer exists on the wrapped module
• github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
◦ Makes the parameter group family configurable so RA3/RG clusters can be managede
• github.com/cloudposse-terraform-components/aws-redshift/pull/50
◦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
• github.com/cloudposse-terraform-components/aws-redshift/pull/49
◦ Removes an output that no longer exists on the wrapped module
• github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
◦ Makes the parameter group family configurable so RA3/RG clusters can be managede
Michal Tomaszekabout 2 months ago
Could someone review this version pinning PR?
github.com/cloudposse/github-action-matrix-extended/pull/25
github.com/cloudposse/github-action-matrix-extended/pull/25
Ben Smith (Benbentwo)about 2 months ago
github.com/cloudposse/terraform-aws-s3-log-storage/pull/141 looks a little stuck -
/terratest looks to have run for some checks but not all - @Andriy Knysh (Cloud Posse) if you get a moment could you take a lookMichael2 months ago
One more (small) AWS Backup improvement for supporting
schedule_expression_timezoneif anyone has a chance to review:github.com/cloudposse/terraform-aws-backup/pull/109Michael2 months ago
If anyone has a chance to review this, it adds to ability to
force_destroy on the AWS Backup Vault: github.com/cloudposse/terraform-aws-backup/pull/108Ihor Urazov3 months ago
Ivan Pinatti3 months ago
This PR is from Renovate and is stuck, someone could review and unblock it please?
• github.com/cloudposse-terraform-components/aws-waf/pull/73
• github.com/cloudposse-terraform-components/aws-waf/pull/73
Michal Tomaszek3 months ago
Hey, follow-up of yesterday's PR:
github.com/cloudposse-terraform-components/aws-github-repository/pull/60
github.com/cloudposse-terraform-components/aws-github-repository/pull/60
MP3 months ago
Hello, could you review this PR ? github.com/cloudposse/atmos/pull/2914
Here is the issue as well => github.com/cloudposse/atmos/issues/2913
Here is the issue as well => github.com/cloudposse/atmos/issues/2913
Michal Tomaszek3 months ago
Hey, could you review this PR for
github.com/cloudposse/terraform-github-repository/pull/32
terraform-github-repository ?github.com/cloudposse/terraform-github-repository/pull/32
Jonathan3 months ago(edited)
Hello, the following PRs are ready for (re)review:
• github.com/cloudposse/atmos/pull/2820
• github.com/cloudposse/atmos/pull/2835
• github.com/cloudposse/atmos/pull/2833
• github.com/cloudposse/atmos/pull/2832
• github.com/cloudposse/atmos/pull/2820
• github.com/cloudposse/atmos/pull/2835
• github.com/cloudposse/atmos/pull/2833
• github.com/cloudposse/atmos/pull/2832
Sean3 months ago
Hello, github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/69 has been created to bring the defaults & functionality in line with the current cert-manager while providing the ability to retain older version behaviors if desired
Michael3 months ago
Would I be able to get one more PR review on this EKS feature?
github.com/cloudposse/terraform-aws-eks-cluster/pull/261
github.com/cloudposse/terraform-aws-eks-cluster/pull/261