#pr-reviews - July 2025

17 messages

Pull Request Reviews for Cloud Posse Projects

Jan Costandius
Jan Costandiusover 1 year ago
My PR has been hanging around for 3 weeks now. Any chance that there's capacity to have a look at it?

https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/123
Bruce
Bruceover 1 year ago
can i get a review for this? its an automated PR:
https://github.com/cloudposse/terraform-aws-budgets/pull/61
Jan Costandius
Jan Costandiusover 1 year ago
AWS v6 provider compatibility fix for the ECS cluster module.

https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/67
Michael
Michaelover 1 year ago
Tiny PR to use this unused Helm chart description variable: https://github.com/cloudposse-terraform-components/aws-eks-reloader/pull/41
Kiryl Kaminski
Kiryl Kaminskiover 1 year ago(edited)
Hello there👋 Any chance to review my PR? Fixes issue #36
https://github.com/cloudposse/terraform-aws-cloudwatch-events/pull/44
Michael
Michaelover 1 year ago
Another tiny PR for updating the default ingress_cidr_blocks: https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/35
Jakub Wądołowski
Jakub Wądołowskiover 1 year ago
a small PR that enables atmos-powered doc generation for Lambda@Edge TF submodule: https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/347
Michael
Michaelover 1 year ago
Would I be able to get another review on adding performance insights to the DocumentDB component? https://github.com/cloudposse-terraform-components/aws-documentdb/pull/20
RobertM
RobertMover 1 year ago
Hi,
Could you review this small PR, please? It’s needed because support for kibana_endpoint attribute was removed from aws_opensearch_domain in hashicorp/aws v6.x.
Jan Costandius
Jan Costandiusover 1 year ago(edited)
I've written a PR to enable support for ECS Service autoscaling. Here it is: https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/269
Jan Costandius
Jan Costandiusover 1 year ago
Hi all, is there any chance that we can close out https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/67?
Quentin BERTRAND
Quentin BERTRANDover 1 year ago
Michael
Michaelover 1 year ago
Hey team, Datadog has updated the full IAM policy for the Datadog Integration (again)... It expands the current policy by 147 permissions to support covering newer AWS services like Bedrock, Macie, etc. I opened a PR to adopt this updated policy: https://github.com/cloudposse/terraform-aws-datadog-integration/pull/78
Tyler Rankin
Tyler Rankinover 1 year ago
Would appreciate a look at this https://github.com/cloudposse/terraform-aws-acm-request-certificate/pull/92 whenever folks have the time.

I apologize it’s been awhile since I contributed, and I’m not sure if I have a local misconfiguration or if there are other changes needed but I’m unable to issue atmos test run. Guessing my config doesn’t pull down the shared config/commands from atmos.yaml
Error: unknown command "test" for "atmos"
Run 'atmos --help' for usage.
unknown command "test" for "atmos"
Jakub Wądołowski
Jakub Wądołowskiover 1 year ago
hey, I've just backported a bunch of improvements from cloudposse/cloudfront-cdn/aws to cloudposse/cloudfront-s3-cdn/aws : https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/340

Could you have a look at that please?
Yevdokiia Mazhak
Yevdokiia Mazhakover 1 year ago
hello!
would it be possible to review this pr: https://github.com/cloudposse/terraform-aws-sns-lambda-notify-slack/pull/69? the 7.0.0 version of terraform-aws-modules/notify-slack/aws also has a constraint of required_version = ">= 1.5.7" for terraform, so its also worth considering to change the terraform constraint in versions.tf
Cilas Beltrame
Cilas Beltrameover 1 year ago
Hi all, PR allowing EB environment more compatible with EB application module, also fixing terratest for this module.
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/279