#pr-reviews - May 2025

12 messages

Pull Request Reviews for Cloud Posse Projects

Michael
Michaelover 1 year ago
Would I be able to get a quick review on these tflint-identified component updates?
https://github.com/cloudposse-terraform-components/aws-cognito/pull/19
Michael
Michaelover 1 year ago
One more PR here for adding route53 health checks as a new feature to cluster hostname component (feel free to not adopt, just wanted to toss it out there)
https://github.com/cloudposse/terraform-aws-route53-cluster-hostname/pull/67
Pablo Paez
Pablo Paezover 1 year ago
Michael
Michaelover 1 year ago
Would I be able to get a quick review on adding additional null handling to outputs for the msk component? Make the destruction cleaner in our environment: https://github.com/cloudposse-terraform-components/aws-msk/pull/21
J
Jover 1 year ago(edited)
Hey guys, the backup module VSS option is broken. Someone posted a fix in the PR https://github.com/cloudposse/terraform-aws-backup/pull/96. Can we merge this?
Michael
Michaelover 1 year ago
Here's a small PR to consolidate enabled logic into a single local for the DocumentDB module: https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/117
Joe Niland
Joe Nilandover 1 year ago
Olaf Bado
Olaf Badoover 1 year ago
Michael
Michaelover 1 year ago
Here's a small follow-up PR to fix the invalid count bug in the DocumentDB module. I think this should do it: https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/118
Jakub Wądołowski
Jakub Wądołowskiover 1 year ago
here's an improvement for variable defaults in the cloudposse/cloudfront-cdn/aws module: https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/149
Romulo Franca
Romulo Francaover 1 year ago
Hey folks, opened this PR to add EKS Auto Mode support (issue #246) https://github.com/cloudposse/terraform-aws-eks-cluster/pull/253 — Could you please take a look?
Chris Dobbyn
Chris Dobbynover 1 year ago
Opened this PR to enable cloudposse/rds/aws to support the new database_insights_mode:
https://github.com/cloudposse/terraform-aws-rds/pull/195