#pr-reviews - April 2025

hey, I've just submitted a bunch of cloudposse/terraform-aws-cloudfront-cdn improvements/fixes:

1. gRPC support: https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/142
2. Keep TF plan idempotent: https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/141
3. Improve origin control: https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/140

I ran into an issue when trying to turn on s3 notifications when using the cloudposse/cloudtrail-s3-bucket/aws module, but under the hood, it looks like that's tied to the s3 module that the cloudtrail module is calling. I created this issue and pr but was curious if I could get some 👀 on it.

Hi 👋🏻
I've created a PR to bump the api-gateway version in https://github.com/cloudposse-terraform-components/aws-api-gateway-rest-api/pull/16
Could you please take a look?

Related thread: https://sweetops.slack.com/archives/CUJPCP1K6/p1741862719610719

Just opened a simple bastion component improvement, but I believe tests haven't been merged yet (https://github.com/cloudposse-terraform-components/aws-bastion/pull/17)

Here are two PRs to help reduce the continual drift introduced by k8s managed resources:

https://github.com/cloudposse-terraform-components/aws-eks-spacelift-worker-pool/pull/16
https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/19

here's yet another improvement to terraform-aws-cloudfront-cdn to keep the module definition concise and improve version upgrades:

https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/147

in order to register my ECS app into multiple target groups, I had to extend the terraform-aws-ecs-web-app module. Here's the PR:

https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/297

Looking for some help on this PR to understand why the tests are failing: https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/115

It's a relatively simple change and it would be great to get this functionality merged in. The test failing as far as I can tell is not related to the changes I made.

a very simple PR that added ingress SGs to ALB module https://github.com/cloudposse/terraform-aws-alb/pull/196

Small PR to add the ability to manage Performance Insights for DocumentDB clusters in the component (Note: the module already supports the functionality):
https://github.com/cloudposse-terraform-components/aws-documentdb/pull/20

Hello, I’m waiting for a fix on my PR here as per this comment: https://github.com/cloudposse/terraform-aws-ses-lambda-forwarder/pull/63#issuecomment-2751750583

I think it got lost along the way. Could someone please have a look at it? Thanks a lot!

These deprecation fixes are generated from TFLint on the Cognito component: https://github.com/cloudposse-terraform-components/aws-cognito/pull/19

Evening, created my very first open source PR today for the cloudposse Terraform Transfer Family module. Ok to get a review on this, please? 🙂
https://github.com/cloudposse/terraform-aws-transfer-sftp/pull/73

Thoughts on this pr?

https://github.com/cloudposse/terraform-aws-iam-policy/pull/52