#pr-reviews - November 2024

13 messages

Pull Request Reviews for Cloud Posse Projects

November 2024
Ray Finch
Ray Finchalmost 2 years ago
Yangci Ou
Yangci Oualmost 2 years ago(edited)
Hey all! Can I request some help / someone to look at Cloudposse's terraform-aws-alb module, the CI is failing to release a new version after a most recent PR merge. It's throwing an error about the README.md.gotmpl, but I've noticed that it hasn't even been changed in the past 6 months. Hopefully someone with more context can help out? Here is the error https://github.com/cloudposse/terraform-aws-alb/pull/190#issuecomment-2470455978 - Thanks!
RB
RBalmost 2 years ago
RB
RBalmost 2 years ago
Please review correct usage of new destination.bucket key

https://github.com/cloudposse/terraform-aws-s3-bucket/pull/256
RB
RBalmost 2 years ago
Please review eventbridge support in event notifications

https://github.com/cloudposse/terraform-aws-s3-bucket/pull/255
RB
RBalmost 2 years ago
RB
RBalmost 2 years ago
Michal Tomaszek
Michal Tomaszekalmost 2 years ago
Hamza Olol
Hamza Ololalmost 2 years ago
Hey all, Can I please have this PR reviewed
https://github.com/cloudposse/terraform-aws-ec2-instance/pull/212

Currently blocking me and forcing me to go a longer way round to solve (adding resources on top of the localised module)
RB
RBalmost 2 years ago
Please review adding an option to use inline policies instead of managed policies for iam roles

https://github.com/cloudposse/terraform-aws-iam-role/pull/79
Ihor Urazov
Ihor Urazovalmost 2 years ago
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/245 please

(feedback about ia bot review: it's garbage and it wasted my time)