#pr-reviews - October 2024

19 messages

Pull Request Reviews for Cloud Posse Projects

October 2024
Lennart Goedhart
Lennart Goedhartabout 2 years ago
RB
RBabout 2 years ago
Michael
Michaelabout 2 years ago
If it's not too late to add this contribution to the AWS components, I can always hold of until after the migration (https://github.com/cloudposse/terraform-aws-components/pull/1143)
david
davidabout 2 years ago
Ray Finch
Ray Finchabout 2 years ago
irl
irlabout 2 years ago
It's been two weeks and I'm still waiting for a review on https://github.com/cloudposse/build-harness/pull/388. How long do reviews typically take?
irl
irlabout 2 years ago(edited)
This is a two character change.
Markus
Markusabout 2 years ago
It's been a while since I last contributed, but I just created a small PR to allow specifying the environment for dns-delegated in the efs component. https://github.com/cloudposse/terraform-aws-components/pull/1164
Markus
Markusabout 2 years ago
Ray Finch
Ray Finchabout 2 years ago
Hey all, looks like https://github.com/cloudposse/terraform-aws-dms/pull/36 is ready to go. Can we merge it?
Markus
Markusabout 2 years ago(edited)
Small bugfix for the above PR to change an invalid parameter type: https://github.com/cloudposse/terraform-aws-dms/pull/37 Seems like my contributions are not needed anymore since another PR got merged for this.
Ray Finch
Ray Finchabout 2 years ago
Hey all, a bugfix for the PR I submitted last week: https://github.com/cloudposse/terraform-aws-dms/pull/38
Michael
Michaelabout 2 years ago(edited)
Came across some interesting interplay between inspection levels and machine learning parameters in the WAF module today. Thought this code comment might be beneficial to the broader community utilizing these features: https://github.com/cloudposse/terraform-aws-waf/pull/104

And another to deprecate resource_collection_enabled in favor of extended_resource_collection_enabled in the Datadog Integration module: https://github.com/cloudposse/terraform-aws-datadog-integration/pull/66
Bob Berg
Bob Bergabout 2 years ago
Michael
Michaelabout 2 years ago
Have been working on the Datadog Integration component recently and was wondering if I would be able to get a review on this PR to add additional IAM policies recommended by Datadog? https://github.com/cloudposse/terraform-aws-datadog-integration/pull/68
RB
RBabout 2 years ago
Please review valkey support for elasticache-redis terraform component

https://github.com/cloudposse/terraform-aws-components/pull/1170
RB
RBabout 2 years ago
Please review snapshot retention limit support for elasticache-redis terraform component

https://github.com/cloudposse/terraform-aws-components/pull/1171
M
Mabout 2 years ago
Michael Dizon
Michael Dizonabout 2 years ago