#pr-reviews - December 2024

7 messages

Pull Request Reviews for Cloud Posse Projects

December 2024
Bob Berg
Bob Bergalmost 2 years ago
https://github.com/cloudposse/terraform-datadog-platform/pull/109

An update to Terraform Datadog Platform. Adding a field that was previously excluded, resulting in only the default value being used.
Jeremy G (Cloud Posse)
Jeremy G (Cloud Posse)almost 2 years ago
@Ray Finch @Yangci Ou @M As I am working on the RDS cluster module (see previous thread), I'm looking over other open PRs. Does PR 230 look correct to you? In my understanding, db_cluster_instance_class would never be relevant.
Josh Simmonds
Josh Simmondsalmost 2 years ago
👋 We have a small bug fix for the aws-dynamic-subnets module (cc @John Seekins) we'd love to get merged in to unblock some work we're doing: https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/217 🫶
Josh Simmonds
Josh Simmondsalmost 2 years ago(edited)
https://github.com/cloudposse/atmos/pull/849 -- Minor change to the json being written to have greater support with existing end-of-file linters/pre-commit hooks (eg https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/end_of_file_fixer.py)
Michael
Michaelalmost 2 years ago
Some of our TFLint workflows and pre-commit hooks throw an error because of the Terraform 0.12 legacy dot index syntax (splat operator). This is a minor PR that cleans up the legacy splat operator in the eks/reloader component (https://github.com/cloudposse-terraform-components/aws-eks-reloader/pull/10)
Sushmitha Kumar
Sushmitha Kumaralmost 2 years ago
Hi #pr-reviews, I’ve updated our Terraform code to replace deprecated splat expressions used in version 0.12.0, aligning it with the 0.12.0+ format. Could someone please review the PR and share feedback? Your input will ensure we maintain compatibility and best practices. here is the PR : https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/12 . Thanks in advance !
Sushmitha Kumar
Sushmitha Kumaralmost 2 years ago
Hi #pr-reviews, Please review this PR for the aws-account-quotas repository. It includes a minor correction to align the splat expression with the Terraform 0.12.0+ format.https://github.com/cloudposse-terraform-components/aws-account-quotas/pull/7