#pr-reviews - May 2024

20 messages

Pull Request Reviews for Cloud Posse Projects

Frank
Frankover 2 years ago
https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/227

I added support for Serverless Redis to this module
Ben
Benover 2 years ago
Hey there, can someone have a look at this PR discussion?
https://github.com/cloudposse/terraform-aws-lb-s3-bucket/pull/82#issuecomment-2090913789
It’s about the correct use of the null label module to generate a default bucket name.
Duleendra
Duleendraover 2 years ago
Hi Team, Gret help if you guys can help to review this PR https://github.com/cloudposse/terraform-aws-waf/pull/57
RB
RBover 2 years ago
Very small PR (one-liner). Adding a try() around a length() function to stop it from throwing an error.

https://github.com/cloudposse/terraform-aws-rds/pull/179
Kamil Grabowski
Kamil Grabowskiover 2 years ago
Could you please review this pull request: https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149
It would be nice to have this feature merged
RB
RBover 2 years ago
In PR https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/230/files

• The tflint step is failing here due to a github token issue
• The codeowners are set to admins
Is this repo out of date?
Ray Finch
Ray Finchover 2 years ago
Ercan Ermis
Ercan Ermisover 2 years ago
Ercan Ermis
Ercan Ermisover 2 years ago(edited)
Hello, I need a PR review. Thanks 🙏 ref: https://github.com/cloudposse/terraform-aws-ec2-instance/pull/197
Ihor Urazov
Ihor Urazovover 2 years ago
RB
RBover 2 years ago
Could i get some help with the failing checks in this pr ?

https://github.com/cloudposse/terraform-aws-components/pull/1032
Ercan Ermis
Ercan Ermisover 2 years ago
hello all, new PR is here 🙂 I’m eating 🐛 https://github.com/cloudposse/terraform-aws-rds/pull/181 thank you for your time and effort! best! ❤️
Joe Niland
Joe Nilandover 2 years ago
Duleendra
Duleendraover 2 years ago
Hi Team, help to review this https://github.com/cloudposse/terraform-aws-waf/pull/79 .
While using the WAF module we noticed this part is missing and just thought to raise the PR. Thank you
RB
RBover 2 years ago
Could I get a PR review for overriding the dynamodb table name ?

https://github.com/cloudposse/terraform-aws-components/pull/1016
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 2 years ago
Eligio Mariño
Eligio Mariñoover 2 years ago
Hi. Could you please review this MR in the AWS DocumentDB module?
https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/94
Marat Bakeev
Marat Bakeevover 2 years ago
Please have a look at this trivial PR, that would fix issue in the terraform-aws-components
https://github.com/cloudposse/terraform-aws-components/pull/1048
Quentin BERTRAND
Quentin BERTRANDover 2 years ago
Hello,
Small PR to add missing AMI type in EKS Node group module
https://github.com/cloudposse/terraform-aws-eks-node-group/pull/182
Eligio Mariño
Eligio Mariñoover 2 years ago
Hi. Is it possible to continue the review? The terratest command and the rest of checks have passed.
https://sweetops.slack.com/archives/CUJPCP1K6/p1716842653008469