#pr-reviews - June 2024

13 messages

Pull Request Reviews for Cloud Posse Projects

Maurice
Mauriceover 2 years ago
Hey everyone, could someone please take a look at the AWS account used for terratest? Specifically, tests for https://github.com/cloudposse/terraform-aws-rds-cluster/pull/184 are failing because the VPC quota is exhausted: https://github.com/cloudposse/terraform-aws-rds-cluster/pull/184#issuecomment-1968534802.

I tried to re-trigger the tests, but the bot ignores my comments (good, because I'm not a project member or anything 😅)
Ray Finch
Ray Finchover 2 years ago
Hi All, could someone take a look at https://github.com/cloudposse/terraform-aws-rds-cluster/pull/213? I had to rebase my branch.
el
elover 2 years ago
hey everyone 👋 just submitted my first PR! https://github.com/cloudposse/terraform-aws-rds-cluster/pull/216 would love a review of the change itself & the question in the description about a strange default value I noticed
Ray Finch
Ray Finchover 2 years ago
Quentin BERTRAND
Quentin BERTRANDover 2 years ago
Hello, could you review this PR please? It add support of AL2023 on EKS Node Group module
https://github.com/cloudposse/terraform-aws-eks-node-group/pull/185
Yangci Ou
Yangci Ouover 2 years ago
Hey all! Appreciate a review on PR https://github.com/cloudposse/terraform-aws-components/pull/1063 for adding backup configs to RDS cluster in the components repo
Frank
Frankover 2 years ago
Bryan Dady
Bryan Dadyover 2 years ago
terraform-cloudflare-zone !43 is ready for review
Diego Rabatone Oliveira
Diego Rabatone Oliveiraover 2 years ago
Hey folks!
Nice to be around! and congrats for the wonderful work!

I am working with the https://github.com/cloudposse/terraform-opsgenie-incident-management module and I've crafted some PRs with some improvements and a also an abstraction suggestion:

Improvements:
• [Notification Policy] Imrprove module
• [escalation] Single recipient per rule
• [Existing Resources] Add Team and Schedule
• [schedule_rotation] Allow "none" as rotation participant
New abstraction:
• [config] Add squad intermediate abstraction
Let me know what you think about it and if I need to make changes 🙂
Eligio Mariño
Eligio Mariñoover 2 years ago
Hi. Could you please review this PR to update the test framework in terraform-aws-documentdb-cluster.
https://github.com/cloudposse/terraform-aws-documentdb-cluster/pull/100
Jeremy G (Cloud Posse)
Jeremy G (Cloud Posse)over 2 years ago
@Eligio Mariño Thank you for this PR. It looks pretty good. I would like to add to it over the weekend if you don't mind waiting.
Moritz
Moritzover 2 years ago(edited)
Please re-run terratest for this PR (the issue in the dependency should be fixed): https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/258
Quentin BERTRAND
Quentin BERTRANDover 2 years ago
Hi, could you review this PR please?
It adds a depends_on for EB env
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/267