#pr-reviews - April 2024

5 messages

Pull Request Reviews for Cloud Posse Projects

Chris Dobbyn
Chris Dobbynover 2 years ago
Simple PR to do some type enforcement on null label:
https://github.com/cloudposse/terraform-null-label/pull/158

Ran into too many people using enabled = "false" instead of enabled = false and this will fix that.
RB
RBover 2 years ago
Please review https://github.com/cloudposse/terraform-aws-dynamodb/pull/126 to override the dynamodb table name without having to override the context inputs
Simon Heather
Simon Heatherover 2 years ago
Can someone approve the GitHub workflow on https://github.com/cloudposse/terraform-aws-cloudtrail/pull/70
Simon Heather
Simon Heatherover 2 years ago
kevcube
kevcubeover 2 years ago
Hello, just put up some PRs in aws-amplify-app (#32, #33) and realized that all Terratests in this repo are still broken due to Github Token issues. See discussion here about this breakage. Can I request that someone with Cloudposse github management permissions takes a look at this issue? Outside contributor @sestrella has been very patient and helpful during discovery of this github token issue