#pr-reviews - September 2022

Hello! I have a PR for the terraform-aws-transit-gateway module (https://github.com/cloudposse/terraform-aws-transit-gateway/pull/29). It allows the amazon_side_asn to be specified for the purpose of both having multiple transit gateways in the same deployment to have different ASNs (following AWS's documented best practices), as well as to allow importing an existing transit gateway with a non-default ASN without needing to destroy and recreate it.

Hi there, I found a Bug (or not a bug, but more a missing feature) in the cloudposse/s3-bucket/aws module (https://github.com/cloudposse/terraform-aws-s3-bucket) which I was able to trace down to the cloudposse/iam-s3-user/aws module and the cloudposse/iam-system-user/aws module (the last one introduced the max age for the expirable access token and set that to a default of 30 days, which currently can't be influenced in the s3 module).

I created two PRs to solve the problem

https://github.com/cloudposse/terraform-aws-iam-s3-user/pull/47
https://github.com/cloudposse/terraform-aws-s3-bucket/pull/155

How can I make sure these two PRs are getting merged and/or how can I align/adjust my changes to fulfil (to me currently unknown) requirements?

Hi there, simple change. It adds aws_default_route_table that gets create automatically with every aws_vpc resource.
https://github.com/cloudposse/terraform-aws-vpc/pull/110

just added an output to acm module:
https://github.com/cloudposse/terraform-aws-acm-request-certificate/pull/59

from terraform aws provider documentation:
It deals with requesting certificates and managing their attributes and life-cycle. This resource does not deal with validation of a certificate but can provide inputs for other resources implementing the validation. It does not wait for a certificate to be issued. Use a aws_acm_certificate_validation resource for this.

Please review

• https://github.com/cloudposse/terraform-aws-acm-request-certificate/pull/54/files
• https://github.com/cloudposse/terraform-aws-acm-request-certificate/pull/61/files

Can someone take a look at https://github.com/cloudposse/terraform-aws-rds-db-proxy/pull/11 ??

@praneeth has joined the channel

I don't know if this is necessarily the right channel, but I'd like to revert the behavior introduced in PR #142. I created an issue to explain why, but maybe I'm missing something.

Can I get some help figuring out why the pipelines are failing? Looks like the error is happening in the step that updates the Status of the run in the PR

https://github.com/cloudposse/terraform-aws-ec2-instance/pull/141