#pr-reviews - October 2022

16 messages

Pull Request Reviews for Cloud Posse Projects

October 2022
M
Mabout 4 years ago
Quentin BERTRAND
Quentin BERTRANDabout 4 years ago
Hello
I opened this PR to add the option table_class to the DynamoDB module 🙂
https://github.com/cloudposse/terraform-aws-dynamodb/pull/106
Joe Niland
Joe Nilandabout 4 years ago
Quentin BERTRAND
Quentin BERTRANDabout 4 years ago
Hello 🙂
Another PR, could you review it 🙏 ?
https://github.com/cloudposse/terraform-aws-cloudtrail-s3-bucket/pull/66
M
Mabout 4 years ago
PR to not create CodePipeline resources when it is disabled
https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/210
Karina Titov
Karina Titovabout 4 years ago
Hi! PR to add an ability to set the custom iam policy name https://github.com/cloudposse/terraform-aws-iam-role/pull/50
Karina Titov
Karina Titovabout 4 years ago
Hi everyone! https://github.com/cloudposse/terraform-aws-iam-role/pull/50 i got 1 approval on my pr, but still can not merge, could somebody please help me merge
Karina Titov
Karina Titovabout 4 years ago
@Cody Moore
Comrumino
Comruminoabout 4 years ago(edited)
Hi all,
I made two PRs that relatively small changes. Lmk if I need to fix/change anything. #215 resource specification would be the part most worth reviewing. #214 is a simple argument update to stop using deprecated one
• https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/214
• https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/215
M
Mabout 4 years ago
seeing an older one here that passed tests. can it go in? https://github.com/cloudposse/terraform-aws-alb-ingress/pull/57