#pr-reviews - August 2022

14 messages

Pull Request Reviews for Cloud Posse Projects

August 2022
Cody Moore
Cody Mooreover 4 years ago
Hey crew, a buddy and I are working on some EKS changes, would love a review on this whenever someone gets a chance: https://github.com/cloudposse/terraform-aws-eks-node-group/pull/126 (needs another reviewer besides me 🙂 )
Andrew Roth
Andrew Rothover 4 years ago
Sam Skynner
Sam Skynnerabout 4 years ago
https://github.com/cloudposse/terraform-aws-ssm-tls-self-signed-cert/pull/14
If possible 🙏
This breaks a number of other modules right now which are dependent on this
Oscar Jara
Oscar Jaraabout 4 years ago
Hi all.
I think I found a bug in the terraform-aws-ecs-web-app module. EFS volumes are not being correctly set in the resulting task definition by the the terraform-aws-ecs-alb-service-task
Draft PR here.
Who can I discuss this with?
Thanks!
matharoo
matharooabout 4 years ago(edited)
Hi, can i please get this merged https://github.com/cloudposse/terraform-aws-rds-cluster/pull/149, the required changes have been made and tests have passed. Thanks 🙂
Tommy
Tommyabout 4 years ago
another PR needs some progress, someone can help? https://github.com/cloudposse/terraform-aws-ec2-instance/pull/117
Mikhail Naletov
Mikhail Naletovabout 4 years ago
Could somebody take a look? Cloudflare removed two fields from healthcheck in 3.20. I already commented about bump supported version in required providers

https://github.com/cloudposse/terraform-cloudflare-zone/pull/7
Tommy
Tommyabout 4 years ago
kevcube
kevcubeabout 4 years ago(edited)
matharoo
matharooabout 4 years ago
Hello guys, i have a PR for terraform aws rds cluster @ https://github.com/cloudposse/terraform-aws-rds-cluster/pull/149 .. its approved. Can i please get a ETA when this can be merged? Its a blocker for us. Thank you :)
Vladimir S.
Vladimir S.about 4 years ago
Could someone take a look pr pls