#pr-reviews - February 2021

20 messages

Pull Request Reviews for Cloud Posse Projects

February 2021
Frank
Frankover 5 years ago
Patrick Jahns
Patrick Jahnsover 5 years ago
Regarding - https://github.com/cloudposse/terraform-aws-eks-node-group/pull/54 - there are some open questions that I am not able to answer ( in terns of aws-provider requirements and cloudposse customers ) - anyone that could chime in and provide a path forward? Would be amazing to have more than a single instance type in a spot instane node group
Frank
Frankover 5 years ago
Can someone take a look at this one? https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/113 Thanks!
Leo Zavala
Leo Zavalaover 5 years ago
@Erik Osterman (Cloud Posse)
Hi all,

I am getting the following from the ECS web app module using webhooks.
I am guessing its coming from the webhooks module.
It seems GitHub there are breaking changes with the GitHub provider.

Warning: Additional provider information from registry

The remote registry returned warnings for
<http://registry.terraform.io/hashicorp/github|registry.terraform.io/hashicorp/github>:
- For users on Terraform 0.13 or greater, this provider has moved to
integrations/github. Please update your source in required_providers.



Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider
hashicorp/github: no available releases match the given constraints ~> 2.8.0,
3.0.0

Leia Renée
Leia Renéeover 5 years ago
@Leia Renée has joined the channel
David Lozano
David Lozanoover 5 years ago
Hi everyone,

Can someone take a look at this one please?
https://github.com/cloudposse/terraform-aws-vpc/pull/81
M
Mover 5 years ago
Leo Zavala
Leo Zavalaover 5 years ago
Joe Hosteny
Joe Hostenyover 5 years ago
Hi folks, seeing a bit of an odd issue on this PR. The build harness readme/build target seems to be non-deterministic from run to run, causing CI to fail.
https://github.com/cloudposse/terraform-aws-codebuild/pull/78
Andrew Roth
Andrew Rothover 5 years ago
Just wrote up https://github.com/cloudposse/charts/issues/266

No PR yet, but I can work on one later if nobody gets to it first
David Lozano
David Lozanoover 5 years ago
Hi all,
Can someone take a look at this one please?
https://github.com/cloudposse/terraform-aws-vpc/pull/81
Bart Coddens
Bart Coddensover 5 years ago
Hi all, I enabled support for the s3 deep archive storage class:
Bart Coddens
Bart Coddensover 5 years ago
can you have a look ?
Bart Coddens
Bart Coddensover 5 years ago
Thx guys !
Leo Zavala
Leo Zavalaover 5 years ago
Hi all, added GitHub Webhooks to the CI/CD module, would someone have a look?
https://github.com/cloudposse/terraform-aws-cicd/pull/89
RB
RBover 5 years ago
nnsense
nnsenseover 5 years ago
Hi there, I don't know how it works with pending PR, will post here for you 🙂
https://github.com/cloudposse/terraform-aws-rds/pull/106