#pr-reviews - January 2021

9 messages

Pull Request Reviews for Cloud Posse Projects

January 2021
Hao Wang
Hao Wangalmost 6 years ago(edited)
Hao Wang
Hao Wangalmost 6 years ago(edited)
do we need list type for all 3 roles, service/execute/task?
Patrick Joyce
Patrick Joycealmost 6 years ago
Patrick Joyce
Patrick Joycealmost 6 years ago
Patrick Joyce
Patrick Joycealmost 6 years ago
Alex Taylor
Alex Tayloralmost 6 years ago
Hello. Is anyone able to help me push through this PR? (I’m currently having to reference my fork in our code which is less than ideal) - It needs approval and unsure as to why the tests are failing as I haven’t changed the default behaviour. Thanks

https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/pull/6
Mikhail Naletov
Mikhail Naletovalmost 6 years ago
loren
lorenalmost 6 years ago
fyi...
Frank
Frankalmost 6 years ago
Hi there. Can someone please take a look at https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/115? The current version (with the default settings) is broken