#pr-reviews - March 2021

https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/127 plz

And https://github.com/cloudposse/terraform-aws-alb-ingress/pull/53 plz

Still says it needs to validate code owners. I saw the other day that someone was able to retrigger that check and it worked. Is there a gitops command for that?

review plz https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/126

Run make init

make init

shell: bash -e -o pipefail {0}

env:

MAKE_INCLUDES: Makefile

BUILD_HARNESS_BRANCH: master

curl: (6) Could not resolve host: git.io

make: *** No rule to make target 'init'. Stop.

Error: Process completed with exit code 2.

🤔

https://github.com/cloudposse/terraform-aws-rds/pull/109 Not sure why the do not merge label was added without any comments

https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/124 Can someone please take a look at this one? Thanks!

https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/115 <-- the 0.35.0 version causes quite a few problems in existing setups. This PR should provide a way to work around that.

hello! looking for a review pretty please https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/93

hey all, I am a bit confused what is needed for this pull request:

hello again, here's one adding more utility to the CDN by passing cache policy ID
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/57

hey all, to proceed pull request 73, I rebased:

could you have a look ?

Hi all, found the time to do this properly. This is a rebase of pull request 73:

Could you have a look ?

A very big thank you to @PePe Amengual for helping me with merging code ! You are one of kind !

here goes the other one:

Hi all, since there have been a few changes on this module lately, can I get a final review of this one too? https://github.com/cloudposse/terraform-aws-codebuild/pull/78

review plz https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/129

review plz https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/60/files

Can someone please take a look at this one: https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/112 ?

And this one: https://github.com/cloudposse/terraform-aws-kms-key/pull/27

Could i please get a review for this ^

All 5 of the open PRs for the asg module are also ready for review 🙂

https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pulls

could I get a review on this https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/131

no, you burn out your Quota for the week

I got some quota left 😉 — particularly for small changes like that one 👍️

Though you need to post an empty commit to re-trigger some failed CI @RB (pat leave again)

review plz https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/131

this guy AGAIN!!!!!!

lol

i saw your comment here https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/131#issuecomment-808486904

the last update on the readme was in line with the automation, no ?

he updated the yaml

mmm no, he needs to only update the yaml

the then run make readme

wouldn’t it be the same result ?

if i ran /rebuild-readme wouldnt it be enough ?

it will fail I think

but the reason behind running the make command is that the readme itself gets updated with the latest too

that makes sense!

it worked https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/131 🎉

not even on the weekends.....

this was even more of a rabbit hole! which lead to this PR #143

Fully removes the template provider from versions.tf. i forgot about this file in my last pr

https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/146

Can someone please take a look at this one? Thanks! 🙂
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/147

another good one from Harry https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/60
thanks in advance!

can i get a review on https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/143

Review plz https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/144

One more small pr https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/142

You folks are probably getting tired of me. Almost done with all the prs in cloudfront cdn!

https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/149

long time ago but we still like you

review plz https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/145