#pr-reviews - May 2020

please review : https://github.com/cloudposse/terraform-aws-rds-cluster/pull/65

No rush on these but want to surface them just to clean up my GH PR list 🙂
1. ssm-parameter-store: Upgrades to work with Terraform v0.12.20
2. test-harness: Fix terraform validate test
3. build-harness: Fixes #207, supplying AWS_DEFAULT_REGION fixes v0.12 INLINECODE_0
4. build-harness: Fixes #149, tf/lint on mac xargs does not support --no-run-if-empty
5. Docs: Fixes up some small mistakes / formatting
Thanks folks!

ya - really sorry about the delays @Matt Gowie

I know it's on @Maxim Mironenko (Cloud Posse) and @Andriy Knysh (Cloud Posse)’s radar ☝️

the SSM module fixes are wanted by a few folks

No worries! Just throwing it out there. Learned some good stuff working through a couple of those, so regardless if they ever ship or not I’m all good

I’m working on terraform-aws-ssm-parameter-store

looks good, just could not trigger the Codefresh test pipeline from the fork for the first time (prob Codefresh issue)

need to copy your PR and put into our repo

I’m waiting for that PR to get merged to push mine to add the S3 logging, KMS encryptions stuff

I’m getting old definitely @Matt Gowie, all this time talking about adding s3 and kms to your ssm module PR and I just realized this is the read module……🤦

What I was talking about is that SSM can be setup in different ways to use it in conjunction with session manager, which does not have any implications to Parameter Store but I was getting confused because the KMS key we use for session manager is the same one we use for parameter store……this must be an old concussion, early alzheimer’s or something

Haha @PePe Amengual I was wondering what you were referring to with that. No worries though — I’ve done that many times too 😅 .

That module does do read and write. Just different vars handle what you’re trying to do.

https://github.com/cloudposse/terraform-aws-s3-bucket/pull/24 Another PR for this

Any takers

@PePe Amengual we'll tackle more PR reviews next week with help from @Marcin Brański

@Marcin Brański has joined the channel

Good evening, Could I get some eyes on https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/21 whenever someone has a few minutes? Thx!

Also this one whenever convenient, https://github.com/cloudposse/terraform-aws-eks-workers/pull/37 Thank you!

@Andrew Mackett has joined the channel

@Sumeet Shukla has joined the channel

Can someone please have a look at this PR?

@Erik Osterman (Cloud Posse) @Andriy Knysh (Cloud Posse) if you guys have some time : https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/33

Hi all. It would be great if anybody has the time to look at this small PR:
https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/69

Thanks!

Hi! It would be great if someone took a look https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/34

https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/34

Hey guys, I added bitbucket (codestar) support in this PR, but I understand if you don’t want to accept it and only support GitHub! :D

@Aziz has joined the channel