#pr-reviews - June 2020

Hello!
Could someone take a look?
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/82

Good morning,
Could I get a review on https://github.com/cloudposse/terraform-aws-s3-bucket/pull/27 when someone has a moment? This replaces pr#23 in the same repo with an alternate/more flexible implementation.

I created 2 more PR’s for the above project that close out a couple of tickets. I would love a review of those also. Thank you!

so sorry everyone - @Andriy Knysh (Cloud Posse) has been out of town this week

np

you're most patient @PePe Amengual 😃

slow and steady you are bound to succeed

https://github.com/cloudposse/terraform-aws-vpc/pulls could some PRs be reviewed for this module? These are open since march 26th.

We are working on increasing our collaborators for Pr reviews

We have started a group with about 7 now. Still writing up the documentation they need to get started. Sorry we have over 270 open PRs

i was going to start using https://github.com/cloudposse/slack-notifier but i want buttons https://api.slack.com/legacy/message-buttons .. i wonder if you could do something like?

SLACK_BUTTON_COUNT=2
SLACK_BUTTON_1_TEXT=approve
SLACK_BUTTON_1_URL=<https://codefresh/${CF_BUILD_ID}/approve>
SLACK_BUTOTN_2_TEXT=deny
SLACK_BUTTON_2_URL=<https://codefresh/${CF_BUILD_ID}/deny>

but erik suggested i might just be better off using gomplate and i think he's right

Good morning! Could someone please take a look at my PR? https://github.com/cloudposse/terraform-aws-ses/pull/2
Thanks!