#pr-reviews - April 2020

Would it be possible to get a review of https://github.com/cloudposse/terraform-aws-s3-log-storage/pull/25 ?

@Andriy Knysh (Cloud Posse) looks like a quick one ☝️ (@Maxim Mironenko (Cloud Posse) is on vacation this week)

Hey any chance I could get a push in the right direction on this PR? https://github.com/cloudposse/terraform-aws-ssm-parameter-store/pull/12

@Mikhail Naletov has joined the channel

Hi!
I'd be very glad if somebody took a look at my PRs

https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/108
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-application/pull/19

Thanks!

Next week we should be faster at reviewing

sorry for the hold up

@PePe Amengual has joined the channel

Thanks for the reviews 🙂

@Joe Niland has joined the channel

[reposted from #terraform]

Hi @Maxim Mironenko (Cloud Posse) would you mind reviewing this PR? I need a bit of help with the bats tests as well. When you have time, I’ll explain what I tried already. Thanks!!
https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/27

another PR for RDS https://github.com/cloudposse/terraform-aws-rds-cluster/pull/64

@cabrinha has joined the channel

I’d love a review of https://github.com/cloudposse/terraform-aws-eks-workers/pull/33 if someone has a few moments. It pretty simple, and just adds the environment value from the label module into the rest of the resources.

Hey folks — I just opened up Issue #207 on build-harness. Is there a reason ya’ll at CloudPosse are printing that message and not running terraform validate? Wanted to check here before I submitted a PR to fix.

@Matt Gowie won't get to this until next week. @Maxim Mironenko (Cloud Posse) working on some other fixes at the moment.

@Erik Osterman (Cloud Posse) No rush at all — I just ran into a handful of CP build-harness/test-harness issues while working on https://github.com/cloudposse/terraform-aws-ssm-parameter-store/pull/12.