#pr-reviews - July 2026

26 messages

Pull Request Reviews for Cloud Posse Projects

Ivan Pinatti
Ivan Pinatti4 months ago
Chris Harden
Chris Harden4 months ago
Can I get a "Approve and run workflows" on github.com/cloudposse/atmos/pull/2674
Thanks!!
Ivan Pinatti
Ivan Pinatti4 months ago
Chris Harden
Chris Harden4 months ago
Can I get another workflow approval on this PR, please?
Chris Harden
Chris Harden4 months ago
Fixed acceptance test for atmos_terraform_apply_help .
Requesting another workflow approval. 🤞
Ivan Pinatti
Ivan Pinatti4 months ago
PR fixing a bug, when possible, could I get a review/approval?
- github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Chris Harden
Chris Harden4 months ago
The acceptance test for windows timed out. Will you please fire it off again?
Michael
Michael4 months ago
Small PR for adding iam_role_arn to the CloudFormation stack module: github.com/cloudposse/terraform-aws-cloudformation-stack/pull/39
PePe Amengual
PePe Amengual4 months ago
PePe Amengual
PePe Amengual4 months ago
PePe Amengual
PePe Amengual4 months ago
Ivan Pinatti
Ivan Pinatti4 months ago
Hey guys, I know you all have been busy. When you can, could someone please review these PRs? I shared them a while ago, but they have not been reviewed yet. They are mostly AWS Utils 2.x bumps and a few minor bug fixes.
• github.com/cloudposse-terraform-components/aws-datadog-credentials/pull/71
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/86
• github.com/cloudposse-terraform-components/aws-teams/pull/65
• github.com/cloudposse-terraform-components/aws-aurora-mysql-resources/pull/53
• github.com/cloudposse-terraform-components/aws-tfstate-backend/pull/78
• github.com/cloudposse-terraform-components/aws-eks-datadog-agent/pull/85
Also, the AWS Utils 2.x compatibility change for aws-aurora-mysql was merged into main, but no release has been cut since then, could someone please cut a version so we can vendor it?
• github.com/cloudposse-terraform-components/aws-aurora-mysql/commit/a62a859e0ae7…
Alex Renoki
Alex Renoki4 months ago
Hi there, I eventually realized there is a lot on the plate for y’all and don’t see the GH notifications. 😅

Wanted to know if my PR regarding atmos.yaml schema (github.com/cloudposse/atmos/pull/2731) is on-par with the current additions in the changelog regarding the atmos stack schema command (github.com/cloudposse/atmos/commit/0485a62a5c75…, github.com/cloudposse/atmos/pull/2761)

Just so I know if I should close the PR and wait for the above PR to be finished.
Marat Bakeev
Marat Bakeev4 months ago
Could anyone have a look at this PR for removing account-map dependency? github.com/cloudposse-terraform-components/aws-spa-s3-cloudfront/pull/68
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)4 months ago
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)4 months ago(edited)
S3 Bucket update to latest module + provider
github.com/cloudposse-terraform-components/aws-s3-bucket/pull/96
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)3 months ago(edited)
One more PR https://github.com/cloudposse-terraform-components/aws-api-gateway-rest-api/pull/55
affected by the
cloudposse/utils: no available releases match the given constraints
  >= 1.7.1, >= 2.0.0, < 2.0.0, < 3.0.0

problem
Ivan Pinatti
Ivan Pinatti3 months ago
Hi everyone, could I get a review on this PR please? It is a bug fix.
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/67
There is a related open PR that is not authored by me that mine is complementing that might be worth checking together;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/66
Ivan Pinatti
Ivan Pinatti3 months ago
Two more PRs, this is to address a specific scenario using these component.
Basically it is just adding a new variable for Global DNS, no functional changes, easy review;
• github.com/cloudposse-terraform-components/aws-eks-cert-manager/pull/68
• github.com/cloudposse-terraform-components/aws-eks-external-dns/pull/66
Jonathan
Jonathan3 months ago
May I get a review for https://github.com/cloudposse/atmos/pull/2819? Thanks!
david
david3 months ago
may I get a review please to allow for not_resources in SCPs? github.com/cloudposse/terraform-aws-service-control-policies/pull/71
Jonathan
Jonathan3 months ago
Jonathan
Jonathan3 months ago
Hi @Erik Osterman (Cloud Posse) let me know if you need anything else for https://github.com/cloudposse/atmos/pull/2820
Jonathan
Jonathan3 months ago
Jonathan
Jonathan3 months ago
Michael
Michael3 months ago
Would I be able to get one more PR review on this EKS feature?

github.com/cloudposse/terraform-aws-eks-cluster/pull/261