#pr-reviews - June 2026

17 messages

Pull Request Reviews for Cloud Posse Projects

Michael
Michael5 months ago
Small PR after running tflint on the s3 bucket module: https://github.com/cloudposse-terraform-components/aws-s3-bucket/pull/82
Miguel Zablah
Miguel Zablah5 months ago
PR to update module to AWS v6 and also update some modules:
https://github.com/cloudposse/terraform-aws-config/pull/141
Quentin BERTRAND
Quentin BERTRAND5 months ago
Hi Clouders!
PR to add ARM usage in EC2 provider
https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/82
Michael
Michael5 months ago
Could I get a review of this change that fixes some tflint findings, typos, and adds support for force_update_version and control_plane_scaling_config for the EKS module?

https://github.com/cloudposse/terraform-aws-eks-cluster/pull/261
Marat Bakeev
Marat Bakeev5 months ago
Hey 👋 Opened a small bug-fix PR for the atmos ansible playbook command: https://github.com/cloudposse/atmos/pull/2594

Bug: any atmos ansible playbook <component> -s <stack> -- <ansible-args> (e.g. -- --check) fails with a misleading Unknown command \<component>`instead of
running the playbook. So there's currently no way to pass native ansible-playbook flags through.

Cause: playbookCmd uses cobra.ExactArgs(1), which counts the passthrough tokens after -- as extra positional args; validation fails and the root UsageFunc
renders it as "Unknown command".

Fix: separator-aware validator that counts only the args before -- (via cobra.ArgsLenAtDash()), matching how terraform / auth shell|exec already handle
passthrough. The executor already forwards post--- args, so this was the only gap. One-function change + regression test, cmd/ansible tests green. Repro'd on
v1.220.0.

Would appreciate a review when someone has a cycle 🙏
Michael
Michael5 months ago
Not sure if the team would have any interest in this but it adds support for govcloud AWS accounts: https://github.com/cloudposse-terraform-components/aws-account/pull/56
Marat Bakeev
Marat Bakeev5 months ago
A small PR to add support for using local instance store disks in karpenter node pools - https://github.com/cloudposse-terraform-components/aws-eks-karpenter-node-pool/pull/73
Marat Bakeev
Marat Bakeev5 months ago
Hi guys, somewhat large bump to cognito component - https://github.com/cloudposse-terraform-components/aws-cognito/pull/63

Let me know if this is not acceptable.
Brian
Brian5 months ago
https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this atmos secret list -s <stack> against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.
Brian
Brian4 months ago
Michael
Michael4 months ago
Would I be able to get a small PR review to add the hosted_zone_id output to the bucket module? github.com/cloudposse/terraform-aws-s3-bucket/pull/293
david
david4 months ago
may we get this old PR reviewed please, github.com/cloudposse/terraform-aws-waf/pull/130? It adds some functionality we are looking for. I can followup with a PR on the component as well
Marat Bakeev
Marat Bakeev4 months ago(edited)
Can this PR get reviewed? github.com/cloudposse-terraform-components/aws-eks-argocd/pull/64
Allows to hide ArgoCD on internal alb and only expose webhooks
Ivan Pinatti
Ivan Pinatti4 months ago
Could I get a pair of eyes on this PR please?
remote-state 1.8.0 → 2.0.0 for utils 2.x compatibility

• github.com/cloudposse-terraform-components/aws-teams/pull/65
david
david4 months ago
Michael
Michael4 months ago
Would I be able to get a review on this PR that fixes the failing tests for the Redshift module? Had to update some of the outdated test values and migrate the logging configuration to the new resource, but everything should be backwards compatible and included in the tests:

github.com/cloudposse/terraform-aws-redshift-cluster/pull/49