#pr-reviews - August 2021

12 messages

Pull Request Reviews for Cloud Posse Projects

August 2021
RB
RBover 5 years ago
and one liner revert to keep backwards compatibility https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/81
Scott
Scottover 5 years ago
Not my PR, but am effected by the issue and following this resolution.. https://github.com/cloudposse/terraform-aws-vpc-flow-logs-s3-bucket/pull/32
Gerald
Geraldabout 5 years ago
Makeshift (Connor Bell)
Makeshift (Connor Bell)about 5 years ago
Could I get a sanity check on this one when people are awake? Thanks 🙂 https://github.com/cloudposse/terraform-null-label/pull/131
Julian Gog
Julian Gogabout 5 years ago
cross-post BUG👋 I’m here! What's up?
I was about to create a bug ticket and and saw the link to your slack. So I want to make sure its a Bug before opening a ticket.
its about the terraform-aws-s3-bucket.
if you specify the privileged_principal_arns option it will never create a bucket policy. Is this a wanted behaviour, since the a aws_iam_policy_document is created?
My guess is that in the the privileged_principal_arns is missing in the count option here:
resource "aws_s3_bucket_policy" "default" {
  count      = local.enabled && (var.allow_ssl_requests_only || var.allow_encrypted_uploads_only || length(var.s3_replication_source_roles) > 0 || var.policy != "") ? 1 : 0
  bucket     = join("", aws_s3_bucket.default.*.id)
  policy     = join("", data.aws_iam_policy_document.aggregated_policy.*.json)
  depends_on = [aws_s3_bucket_public_access_block.default]
}


ok I am almost 100% sure its a bug, so here are the issue and the PR
Bug-Issue: https://github.com/cloudposse/terraform-aws-s3-bucket/issues/100

PR: https://github.com/cloudposse/terraform-aws-s3-bucket/pull/101

RB
RBabout 5 years ago
This pr adds a timeout after the eks is created in order to install coredns kube addon.

Please review

https://github.com/cloudposse/terraform-aws-eks-cluster/pull/126
RB
RBabout 5 years ago
RB
RBabout 5 years ago(edited)
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)about 5 years ago
@RB (pat leave again) you're knocking out tons of fixes!
Florian SILVA
Florian SILVAabout 5 years ago
Hello guys,
When somebody is ready, could I have a review on this feature ?
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/187