#pr-reviews - July 2021

8 messages

Pull Request Reviews for Cloud Posse Projects

azec
azecover 5 years ago
azec
azecover 5 years ago
azec
azecover 5 years ago
Ok, I am now waiting for some more 👀 and 👍️ from administrators on the above 2 PRs …
Florian SILVA
Florian SILVAover 5 years ago(edited)
Hello guys !
Could somebody take time for a quick review of this MR I did a moment ago ? https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/182
It has been ready for a while and is now well tested on my side. Only a strange bridgecrew error failing but with no error.
Matt Gowie
Matt Gowieover 5 years ago
@Florian SILVA Sorry it’s small but here is the thread with BridgeCrew regarding why they’re failing PR checks.

The tl;dr; is that BridgeCrew fails when the PR is from a fork (which is all PRs that don’t come from folks in this channel, so 99% of em).
kevcube
kevcubeover 5 years ago
Hey gang, made a PR to aws-ecs-web-app which enables setting a custom policy/role for the tasks. Please 👀 when you can! TY https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/155
Paul Robinson
Paul Robinsonover 5 years ago
hi all, please could I have 👀 on my PR?
https://github.com/cloudposse/terraform-aws-transit-gateway/pull/11
@Andriy Knysh (Cloud Posse) @Maxim Mironenko (Cloud Posse) this is my first contribution of a few in this repo and I may need some input on my follow on (specifically how to achieve multiple route tables/associations) if you have some time please?
Ihor Urazov
Ihor Urazovover 5 years ago
Hi, looking for review https://github.com/cloudposse/terraform-aws-eks-cluster/pull/123. This is quite crucial, as kube_exec_auth method doesn’t work with latest AWS CLI v1 without this change.