#airship - June 2020

IvanM
IvanMover 6 years ago
hey everyone
Is there pls any update on porting https://github.com/blinkist/terraform-aws-airship-ecs-service to terraform 0.12?
IvanM
IvanMover 6 years ago
or we should just stop praying for that? 🙂
joshmyers
joshmyersover 6 years ago
heh, I was coming to ask the same question
joshmyers
joshmyersover 6 years ago
joshmyers
joshmyersover 6 years ago
joshmyers
joshmyersover 6 years ago
Would you mind me asking what functionality you have working?
Maarten van der Hoef
Maarten van der Hoefover 6 years ago
I'd like to understand if it's more important to have the current module fitted into 0.12 or have a cleaner design based on 0.13.
joshmyers
joshmyersover 6 years ago
By the latter I assume you mean for_each and depends_on for modules etc?
Clayton Wheeler
Clayton Wheelerover 6 years ago
oh hey, hmm, I got pulled away from that so I don't have it quite in release-worthy shape yet like I'd hoped to, but a decent amount. The basics, definitely. I've only done a little bit of load balancing, and haven't touched autoscaling, cron tasks, placement, or volumes at all. But running normal containers esp. with Fargate, using Secrets Manager and IAM, service discovery, repository credentials, that works.
joshmyers
joshmyersover 6 years ago
Wondering what folks are doing to deploy ECS tasks via CI/CD that services etc are managed with Terraform
Clayton Wheeler
Clayton Wheelerover 6 years ago
OK, I made PR #91. Thanks for the nudge on this!
joshmyers
joshmyersover 6 years ago
@Clayton Wheeler / @Mads Hvelplund / @Maarten van der Hoef Looks like https://github.com/Genomenon/terraform-aws-airship-ecs-service/blob/master/modules/live_task_lookup/output.tf#L19 is broken in 0.12
joshmyers
joshmyersover 6 years ago
data "aws_ecs_task_definition" "default" {
  task_definition = "${var.namespace}-${var.name}-${var.environment}-${var.pool}"

  depends_on = [aws_ecs_task_definition.default]
}
joshmyers
joshmyersover 6 years ago(edited)
Adding an explicit depends_on gets over the bootstrap issue so I’m not sure the live lookup stuff is necessary?
joshmyers
joshmyersover 6 years ago
Bah, trying try(data.aws_ecs_container_definition.default.image, local.bootstrap_service_container_image) causes a cyclical dependency