#terraform-aws-modules - May 2023

JoseF
JoseFover 3 years ago
Hello team, the error in the aws-flow-logs is the pending PR open at here https://github.com/cloudposse/terraform-aws-vpc-flow-logs-s3-bucket/pull/52.

Can someone from <!subteam^S0316FFT4M9|@cloudposse-team> check, rebase and approve that s3-logs version upgrade? Same for the
• https://github.com/cloudposse/terraform-aws-s3-bucket
• https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn
Root cause: old s3-logs dependencies to version 0.26.0 in root modules. Upgrade to 1.0.0 minimum is required. Prefered 1.1.0
Jeremy G (Cloud Posse)
Jeremy G (Cloud Posse)over 3 years ago
terraform-aws-utils v1.2.0 is now available, updated to include the newest regions, and now also providing an all_regions output.
JoseF
JoseFover 3 years ago
I definitely appreciate the update of the s3-cdn repo just about 2 minutes ago 🎉
nnsense
nnsenseover 3 years ago(edited)
Hi there, I was implementing your EKS cluster in a terragrunt based environment, as you know terragrunt forces you to be a lot more careful about inputs and outputs, and apparently the region variable is not used anywhere in the module, except for the testing/examples, into the provider. Since that means a further output/input in terragrunt (it's unlikely a big deal with plain terraform as you don't have to deal with each input), would makes sense to remove it from the module's variables.tf? Happy to create a PR if this makes sense to you.
EDIT: On a second thought, since removing it from the variables would require also a change into the module declaration, can I at least set a default?
EDIT 2: Well, at this point I can set a default as a terragrunt input myself 😄. Anyway that region var is unused and should be removed :)
Dan Miller (tembo)
Dan Miller (tembo)over 3 years ago
@Dan Miller (tembo) has joined the channel
Max Lobur
Max Loburover 3 years ago
❗️ All terraform module repos have their default branch renamed from master to main today. You will need to re-clone or:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

Hariprasath Narayanamoorthy
Hariprasath Narayanamoorthyover 3 years ago
Hello colleagues ,
we see when we enable a sns notification as the override variable in terraform , it getting only destroyed and not getting recreated . Any idea why ?
Terraform code :

variable "sns_endpoint" {
  description = "Endpoint for SNS Endpoint"
  type        = string
}

resource "aws_sns_topic_subscription" "user_updates_email_target" {
topic_arn = aws_sns_topic.sap_topic.arn
protocol  = "email"
endpoint  = "${var.sns_endpoint}"
}

Terraform plan :
Plan: 227 to add, 8 to change, 9999 to destroy.

Changes to Outputs:
  ~ account_id = "092716918791" -> "144080655895"

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: ^C