#pr-reviews - September 2026

22 messages

Pull Request Reviews for Cloud Posse Projects

September 2026
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)about 2 months ago
github.com/cloudposse/terraform-aws-s3-log-storage/pull/141 looks a little stuck - /terratest looks to have run for some checks but not all - @Andriy Knysh (Cloud Posse) if you get a moment could you take a look
Michal Tomaszek
Michal Tomaszekabout 2 months ago
Could someone review this version pinning PR?
github.com/cloudposse/github-action-matrix-extended/pull/25
Ivan Pinatti
Ivan Pinattiabout 2 months ago(edited)
Could I please get a review on these 3 PRs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/50
◦ One-line remote-state bump, fixes terraform init which is currently failing on every PR in the repo
• github.com/cloudposse-terraform-components/aws-redshift/pull/49
◦ Removes an output that no longer exists on the wrapped module
• github.com/cloudposse/terraform-aws-redshift-cluster/pull/51
◦ Makes the parameter group family configurable so RA3/RG clusters can be managede
Ivan Pinatti
Ivan Pinattiabout 2 months ago
One more PR, this is a bug in the ssm path, easy review.
• github.com/cloudposse-terraform-components/aws-redshift/pull/51
Ivan Pinatti
Ivan Pinattiabout 2 months ago
Another PR, unrelated with the previous ones. Could I please also get a review?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119
◦ Changes the archive bucket lifecycle default from GLACIER to GLACIER_IR. Datadog can't read GLACIER for rehydration or Archive Search, so on the default config the archive silently becomes unreadable a year after the first object lands.
dmitrijn
dmitrijnabout 2 months ago
Ivan Pinatti
Ivan Pinattiabout 2 months ago(edited)
Could I please get a review on these 4 PRs?
- github.com/cloudposse-terraform-components/aws-redshift/pull/52
- Exposes 17 variables the wrapper does not currently pass through, so encryption, snapshot restore, IAM roles and logging can't be set from a stack
- github.com/cloudposse-terraform-components/aws-redshift/pull/53
- Adds vpc_component_name, which ~8 sibling components already have, plus subnet_ids for stacks with no CloudPosse-managed VPC
- github.com/cloudposse-terraform-components/aws-redshift/pull/54
- Adds scheduled pause/resume support
- github.com/cloudposse/terraform-aws-redshift-cluster/pull/52
- Exposes manual_snapshot_retention_period

Two small things that would help:
• The workflow runs on the three component PRs are sitting on action_required, so terraform CI hasn't reported on any of them yet, could someone approve those runs?
• github.com/cloudposse-terraform-components/aws-redshift/pull/48 passes CI now that the remote-state bump landed. It's been open since June and it's a one-line module bump.
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)about 2 months ago
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)about 2 months ago
Ivan Pinatti
Ivan Pinattiabout 2 months ago
Please could I get a review on this PR?
• github.com/cloudposse-terraform-components/aws-acm/pull/64 - It fixes a bug where the CloudPosse ACM component cannot handle a wildcard domain_name
PePe Amengual
PePe Amengualabout 2 months ago
Ivan Pinatti
Ivan Pinattiabout 2 months ago(edited)
Could I please get an approval review on these two Renovate PRs? Both are green and just blocked on REVIEW_REQUIRED.
• github.com/cloudposse-terraform-components/aws-redshift/pull/55
• github.com/cloudposse-terraform-components/aws-redshift/pull/46
Ivan Pinatti
Ivan Pinattiabout 2 months ago
Could I also get a review on this PR please?
• github.com/cloudposse-terraform-components/aws-acm/pull/65 - Follow-up to the ACM wildcard fix. It adds an optional variable so one account can hold two certificates for the same domain without them overwriting each other's SSM parameter.
Ivan Pinatti
Ivan Pinattiabout 2 months ago
Happy Friday! The last PR for this week, could I please get a review?
- github.com/cloudposse-terraform-components/aws-redshift/pull/56
- Exposes the last five pass-through variables now that the module pin moved to 1.7.0 in #55, including cluster_parameter_group_family which RA3/RG clusters need
Ivan Pinatti
Ivan Pinattiabout 1 month ago
Please could I get a review on this PR?
• github.com/cloudposse-terraform-components/aws-dns-delegated/pull/73 - It adds an option to skip the parent zone lookup when the parent zone lives in a different account
PePe Amengual
PePe Amengualabout 1 month ago(edited)
any reason why the IPAM component used https://github.com/aws-ia/terraform-aws-ipam instead of a cloudposse managed module? last release of the AWS maintained module is a year old, are you guys open on creating a cloudposse owned module? ( I have cycles and interest)
PePe Amengual
PePe Amengualabout 1 month ago
Michael
Michaelabout 1 month ago
If anyone has a chance to review, this adds some SSM functions to the test-helpers package. When we build an AMI with Packer, we use Terraform, Terratest, and SSM to run host checks to ensure it's configured as we intend. Contributing these back to the community for other's use could be beneficial for reusability

github.com/cloudposse/test-helpers/pull/99
Ivan Pinatti
Ivan Pinattiabout 1 month ago
Could I get a review please?
• github.com/cloudposse-terraform-components/aws-datadog-monitor/pull/77 - It unblocks aws-datadog-monitor, where terraform init and terraform validate both fail on main today
Ivan Pinatti
Ivan Pinattiabout 1 month ago
Hey, could I please get a review on this one?
• github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
Ivan Pinatti
Ivan Pinattiabout 1 month ago(edited)
Hello, could I get a review on this PR please?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/122 - Exposes the four Datadog log archive tuning fields the component never wired (compression, partitioning, lookup attributes, scan cap) and defaults compression to ZSTD.
Ivan Pinatti
Ivan Pinattiabout 1 month ago
Hello, could I get a review please?
• github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/123 - Adds query_exclusions so an archive can drop a class of logs, like health checks, without restating the whole query, and applies it to the catchall archive too.