#pr-reviews - August 2024

10 messages

Pull Request Reviews for Cloud Posse Projects

August 2024
Moritz
Moritzover 2 years ago
Could https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/189 please be reopened, the issue with the dependency should be fixed? (cc @kevcube as original author)
Yangci Ou
Yangci Ouover 2 years ago(edited)
Would love to get a review on this PR which adds local file path support for Spacelift policies (in addition to the currently existing inline and http URL support): https://github.com/cloudposse/terraform-spacelift-cloud-infrastructure-automation/pull/183.

One thing to note though is that all the terratest in the repo seem to be failing even for dependency updates (not even at the code level, terraform can't be initalized). Tofu is suceeding. Can someone who's familiar with how Terratest works take a look at that?
+ echo 'Unable to locate executable for terraform '
Unable to locate executable for terraform 
Ray Finch
Ray Finchabout 2 years ago
nnsense
nnsenseabout 2 years ago
Hi, just wanted to bring to your attention https://github.com/cloudposse/terraform-aws-lambda-function/pull/69 by @jpalomaki
I just badly need to use that feature... 😄
Tyler Rankin
Tyler Rankinabout 2 years ago
Hey all! Would appreciate a review on adding support for Origin Access Control to the terraform-aws-cloudfront-s3-cdn component
nnsense
nnsenseabout 2 years ago
Hi there, a very very quick change to the cloudwatch submodule into the lamdba one, to allow the context to be passed to the submodule instead of just vars. Thanks 🙂

https://github.com/cloudposse/terraform-aws-lambda-function/pull/74
Hamza Olol
Hamza Ololabout 2 years ago
Hey all,

Ive opened a PR to the CP subnets module to allow routing to a Transit gateway. Left more details in the pr description, looking forward to getting feedback on this change.

https://github.com/cloudposse/terraform-aws-named-subnets/pull/60
nnsense
nnsenseabout 2 years ago
Hi cloudposse crew! Just a minor addition to the lambda module, allowing to set a Kinesis stream, DynamoDB stream, or SQS queue as a trigger for lambda.
https://github.com/cloudposse/terraform-aws-lambda-function/pull/75
Thanks :)
nnsense
nnsenseabout 2 years ago
For your kind attention 🙂 Another minor addition to allow a user to set a resource policy to the dynamodb module (well.. which is why I asked this 🙂)
https://github.com/cloudposse/terraform-aws-dynamodb/pull/135
Ray Finch
Ray Finchabout 2 years ago
Hey all, what is the status of https://github.com/cloudposse/terraform-aws-dms/pull/30? Changes were requested and they have been implemented