#pr-reviews - December 2023

2 messages

Pull Request Reviews for Cloud Posse Projects

December 2023
Kamil Grabowski
Kamil Grabowskialmost 3 years ago
May I ask about code review once again? The same pull request as before.
This feature is really important for me and I would like to upgrade my redis clusters to 7.1. Also, as you can see other people also are waiting for it (please note that there are a few pull requests about the same feature)
Kamil Grabowski
Kamil Grabowskialmost 3 years ago
May I ask for a code review for this pull request: https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/217
There is a bug in the terraform aws provider: hashicorp/terraform-provider-aws#32835
When importing an aws_elasticache_replication_group resource the attribute security_group_names is imported as null
Currently, we can't import existing aws_elasticache_replication_group without recreate resource: https://github.com/cloudposse/terraform-aws-elasticache-redis/issues/207