#pr-reviews - March 2023

17 messages

Pull Request Reviews for Cloud Posse Projects

Gocho
Gochoover 3 years ago
@Gocho has joined the channel
cinacio
cinacioover 3 years ago
Hi. I've been sent to this channel in case my PR needs a nudge, so here it is:
https://github.com/cloudposse/terraform-aws-ec2-instance/pull/142

It's almost there, but for some reason auto-format fails
Nitin
Nitinover 3 years ago
Terraform test is getting failed on repos because vpc limit is reached for the enviroment.
M
Mover 3 years ago
Quentin BERTRAND
Quentin BERTRANDover 3 years ago(edited)
Hello, I have this PR to review:

Feat: add option to not create target group

I guess it will need a procedure migration of state is this PR is accepted
Josh Baird
Josh Bairdover 3 years ago
kevcube
kevcubeover 3 years ago
Requesting review on this

It is blocking me here because go 1.15 can't build for darwin/arm64
Dan Miller (tembo)
Dan Miller (tembo)over 3 years ago
@Dan Miller (tembo) has joined the channel
dude
dudeover 3 years ago
@dude has joined the channel
Ben Smith (Benbentwo)
Ben Smith (Benbentwo)over 3 years ago
@Ben Smith (Benbentwo) has joined the channel
dude
dudeover 3 years ago
quick reminder that you can press period . while on a pull request to let you add things like terraform highlighting, or to mark directories as 'read'...
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 3 years ago
@Linda Pham (Cloud Posse) can you find someone to help review https://github.com/cloudposse/terraform-aws-eks-node-group/pull/139
Linda Pham (Cloud Posse)
Linda Pham (Cloud Posse)over 3 years ago
@Linda Pham (Cloud Posse) has joined the channel
Anthony B
Anthony Bover 3 years ago
hello! I was looking to get this PR reviewed https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/95
however there does seem to be an issue with permissions it looks like getting a github action to successfully run on my fork. Would I be able to get some advice? Thank you!