#pr-reviews - January 2023

8 messages

Pull Request Reviews for Cloud Posse Projects

January 2023
Bart Coddens
Bart Coddensalmost 4 years ago
Simple upgrade, could someone have a look ?
M
Malmost 4 years ago
Sergey
Sergeyalmost 4 years ago
Hello.
I’m using the “terraform-aws-cloudtrail-s3-bucket” module, but it lacks 2 variables (object_lock_configuration & bucket_key_enabled), I added them to the module:
1) https://github.com/cloudposse/terraform-aws-cloudtrail-s3-bucket/pull/69

2) https://github.com/cloudposse/terraform-aws-cloudtrail-s3-bucket/pull/70

Since the module refers to “terraform-aws-s3-log-storage”, I had to add a variable in it:
3) https://github.com/cloudposse/terraform-aws-s3-log-storage/pull/84

Note that the final module “cloudposse/s3-bucket/aws” already has these variables.
Please approve these changes as soon as possible, the code is tested and works.
Sergey
Sergeyalmost 4 years ago(edited)
Other topic
------------

Hello, I have fixed the bug https://github.com/cloudposse/terraform-aws-cloudwatch-logs/pull/38 Please review as soon as possible. The code has been tested and works.