#pr-reviews - April 2022

8 messages

Pull Request Reviews for Cloud Posse Projects

nnsense
nnsenseover 4 years ago(edited)
Hi guys, here's a PR for adding a "single NGW" option to subnets module, useful during development to save some money.
Feel free to reject it if you don't feel this option should be available, or let me know if there's anything I should change, thanks! 🙂
https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/154

PS - I've tested it creating a VPC with a single NGW, then changed to multiple and back to single changing the new variable
Chris Dobbyn
Chris Dobbynover 4 years ago
Hey all, here's an update to an old PR (from before I knew this channel existed). It adds the ability for multi-az-subnets module to use full, short, or fixed naming (this is copying the work done in dynamic subnets module):
https://github.com/cloudposse/terraform-aws-multi-az-subnets/pull/56

I didn't really change anything except for adding tests.