#pr-reviews - January 2022

3 messages

Pull Request Reviews for Cloud Posse Projects

January 2022
Frank
Frankalmost 5 years ago
Turns out the fix I made earlier does not work in all cases. This one should deal with that.
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/213
David Lozano
David Lozanoalmost 5 years ago
Hi everyone. I’m a little bit confused with the bridgecrew’s comments on the below PR.
Do I need to validate that the new alias records are pointing to resources created in my account? I didn’t see this validation in the repo before my changes.

Are these crewbridge’s comments the reason because the PR is blocked?

https://github.com/cloudposse/terraform-aws-route53-alias/pull/37