#pr-reviews - May 2021

7 messages

Pull Request Reviews for Cloud Posse Projects

Alex Taylor
Alex Taylorover 5 years ago
Alex Taylor
Alex Taylorover 5 years ago(edited)
https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/116
We've created a draft based on the feedback from above ^^

This has added a third ecs service that right now only ignores the changes to desired_count (So we don't have one for both desired count + task definition because right now we don't have the use-case for it, I'd rather that be added later if its needed) - want to know any thoughts on this before creating a PR and changing our code / moving remote state to avoid any unnecessary changes
kevcube
kevcubeover 5 years ago
Hi 👋

Please give a super quick review to This PR
nnsense
nnsenseover 5 years ago
M
Mover 5 years ago
M
Mover 5 years ago
Frank
Frankover 5 years ago