#pr-reviews - August 2020

7 messages

Pull Request Reviews for Cloud Posse Projects

August 2020
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 6 years ago
@OliverS asks:
About https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/3 where do you want to have that conversation, here in DM or in a group channel?
OliverS
OliverSover 6 years ago
@OliverS has joined the channel
Frank
Frankabout 6 years ago
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/34 Can someone please take a look at this one? It's not mine but it would definitly be nice to get this module supported past Terraform 0.11 :)
Frank
Frankabout 6 years ago
Minor modification to this module in preparation of 0.13: https://github.com/cloudposse/terraform-github-repository-webhooks/pull/22
Eric Berg
Eric Bergabout 6 years ago
https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/3
Just added support for ignore_members in the team module. I added it as part of the team map and as a variable, in two commits, for reference. not sure which approach you guys prefer.
Frank
Frankabout 6 years ago
https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/68

I've been working on adding support for Terraform 0.13 for this module. I think I'm there for 99% but the test is currently failing on some Go error and I'm not sure why
Frank
Frankabout 6 years ago
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/37 More prep work for TF 0.13 (this needs to be able to work with 0.12 first).