131 messages
Discuss atmos core development (golang). If you want to help out, reach out to @Erik Osterman (Cloud Posse)
Andriy Knysh (Cloud Posse)about 1 month ago
@Erik Osterman (Cloud Posse) github.com/cloudposse/atmos/pull/3239
Jorrit Elfferichabout 1 month ago
github.com/cloudposse/atmos/pull/3245 is also ready now 🙂. Have 3 PRs open, all touching scaffold, they will likely conflict whenever they get merged, but happy to pick up resolving that once we settle.
Andriy Knysh (Cloud Posse)about 1 month ago
@Erik Osterman (Cloud Posse) github.com/cloudposse/atmos/pull/3270
Andriy Knysh (Cloud Posse)30 days ago
@Erik Osterman (Cloud Posse) github.com/cloudposse/atmos/pull/3273
Jorrit Elfferich28 days ago(edited)
Small fix: github.com/cloudposse/atmos/pull/3279. Noticed it while demo'ing on stage 😏
erik28 days ago
@Andriy Knysh (Cloud Posse) one more pass at improving documentation organization, cross linking, and improving the
<Intro/> of each page. github.com/cloudposse/atmos/pull/3272erik28 days ago
@Andriy Knysh (Cloud Posse) @Igor Rodionov want your help to coordinate the release of this
• Merge #113 and #114 and cut the v2.0.1 and v1.8.1 patch releases.
• Once components pick up the patched module, revert the OpenTofu 1.12.6 pin in .github#186.
This relates to github.com/cloudposse/atmos/issues/3282#…
• Merge #113 and #114 and cut the v2.0.1 and v1.8.1 patch releases.
• Once components pick up the patched module, revert the OpenTofu 1.12.6 pin in .github#186.
This relates to github.com/cloudposse/atmos/issues/3282#…
erik27 days ago
@Andriy Knysh (Cloud Posse) one more pass at improving the DX of the sidebar github.com/cloudposse/atmos/pull/3291
erik27 days ago
@Andriy Knysh (Cloud Posse) this automatically detects how atmos is installed, and recommends the relative upgrade command e.g.
github.com/cloudposse/atmos/pull/3293
brew upgrade atmosgithub.com/cloudposse/atmos/pull/3293
Andriy Knysh (Cloud Posse)26 days ago
@Jorrit Elfferich do you have PRs for review?
erik26 days ago
@Andriy Knysh (Cloud Posse) this adds
github.com/cloudposse/atmos/pull/3297
--labels and --tags filters to the list and describe commands; a /field-test uncovered more rough edges, which is why this PR is largergithub.com/cloudposse/atmos/pull/3297
erik26 days ago
@Andriy Knysh (Cloud Posse) after this we can cut the release github.com/cloudposse/atmos/pull/3316
erik26 days ago
I moved CloudFormation and Scripting PR stacks out of 1.231.0 to 1.232.0
erik25 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3347 many PRs are failing due to a bug in govulncheck's SARIF output
PePe Amengual25 days ago(edited)
has there been reports of describe affected slowing down 40x on 1.231.0?
erik23 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3356 this is to catch future performance regressions; it also introduces an aggregate quality gate, to make it easier for contributors to know what required
erik22 days ago
@Andriy Knysh (Cloud Posse) one more fix for the quality gates github.com/cloudposse/atmos/pull/3367
erik21 days ago
@Andriy Knysh (Cloud Posse) one more trying to tune the quality gates https://github.com/cloudposse/atmos/pull/3376
Jorrit Elfferich20 days ago
Hey folks, saw this gap which I didn't expect, decided to plug it 👀. Keen on your thoughts!
github.com/cloudposse/atmos/pull/3381
github.com/cloudposse/atmos/pull/3381
erik20 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3383 one more fix for quality gate; iti wasn't working for forks
erik19 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3388 (adds social cards for links when shared)
toka18 days ago
Hey guys! First time contributing here, so forgive me if I missed a step. I opened github.com/cloudposse/atmos/pull/3397 with a fix for bulk
terraform deploy skipping planfile verification (issue: github.com/cloudposse/atmos/issues/3396).erik18 days ago
@toka btw, we merged the starlark implementation; it's in main
erik17 days ago(edited)
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3404 I realized we didn't finish supporting full templating of terraform docs in
atmos docserik16 days ago
@Andriy Knysh (Cloud Posse) this introduces
github.com/cloudposse/atmos/pull/3392
The
atmos doctor and atmos doctor --fix which can diagnose many problems, and fix certain deprecations, etc.github.com/cloudposse/atmos/pull/3392
The
doctor command is a common function these days in advanced CLIs.erik16 days ago
@Andriy Knysh (Cloud Posse) this introduces a
github.com/cloudposse/atmos/pull/3405
/regression-test skill as a compliment to the /field-test skill; it specifically tests the current checkout against the previous release and identifies the subtle, unintended changes in behavior. While the field-test skill focuses on finding bugs, this skill focuses on finding bugs relative to the previous release.github.com/cloudposse/atmos/pull/3405
erik16 days ago
@Andriy Knysh (Cloud Posse) this adds a new
github.com/cloudposse/atmos/pull/3395
!ci.labels function useful for using CI context as part of stack configuration (e.g. stack metadata like tags, labels )github.com/cloudposse/atmos/pull/3395
erik16 days ago
Pro tip, you can run
/goal quality-gate approved to get your PRs merge readyerik16 days ago
@Andriy Knysh (Cloud Posse) this PR stack is ready - updates docs
github.com/cloudposse/atmos/pull/3409
github.com/cloudposse/atmos/pull/3418
github.com/cloudposse/atmos/pull/3409
github.com/cloudposse/atmos/pull/3418
erik16 days ago
@Andriy Knysh (Cloud Posse) documentation update github.com/cloudposse/atmos/pull/3419
erik15 days ago
@Andriy Knysh (Cloud Posse) github.com/cloudposse/atmos/pull/3403 (5 PRs in stack - implements atmos policies)
After this we're "ready for release", but I want to still run some regression tests after this stack merges
After this we're "ready for release", but I want to still run some regression tests after this stack merges
erik15 days ago(edited)
@Andriy Knysh (Cloud Posse) when tests finish we're ready to cut 1.233.0 github.com/cloudposse/atmos/pull/3434
these were the only regressions that GPT Astra 6 and Fable 5.1 were able to find relative to 1.232.0
these were the only regressions that GPT Astra 6 and Fable 5.1 were able to find relative to 1.232.0
erik15 days ago
@Andriy Knysh (Cloud Posse) I can't approve this since I pushed a fix; it was failing in merge queue github.com/cloudposse/atmos/pull/3381
Jorrit Elfferich15 days ago(edited)
Hey folks. Something is off, it's probably a timing issue somewhere in the release pipelines:
• The tagged 1.233.0 release points to the git tag
• The release assets added to that release, point to
One-liner to check the sha on the release binary:
whereas:
• The tagged 1.233.0 release points to the git tag
v1.233.0 which points to 12f83b5.• The release assets added to that release, point to
b392e54f7, which is 3 commits before 12f83b5. One-liner to check the sha on the release binary:
d=$(mktemp -d) && gh release download v1.233.0 -R cloudposse/atmos -p atmos_1.233.0_darwin_arm64 -D "$d" && go version -m "$d/atmos_1.233.0_darwin_arm64" | grep vcs.revision; rm -rf "$d"
build vcs.revision=b392e54f74a9c436d2c27fc8ba1b82605e95b58ewhereas:
git ls-remote <https://github.com/cloudposse/atmos> refs/tags/v1.233.0
12f83b5248253662d8af06030e3966034a7ef5d4 refs/tags/v1.233.0erik14 days ago
We surpassed 86% test coverage! Raising the bar to 90% 😃
erik14 days ago
@Andriy Knysh (Cloud Posse) this adds "Try it" examples anywhere we have one. Users can easy try examples locally, no manual cloning required.
github.com/cloudposse/atmos/pull/3447
github.com/cloudposse/atmos/pull/3447
erik12 days ago
@Andriy Knysh (Cloud Posse) ready to merge this now github.com/cloudposse/atmos/pull/3474 and try the release process out
erik12 days ago
@Andriy Knysh (Cloud Posse) DNS fix finally ready github.com/cloudposse/atmos/pull/3493
erik12 days ago
@Andriy Knysh (Cloud Posse) new releae process PR is ready; we'll cut patch release tomorrow, and then start merging the backlog of PRs for 1.234.0 if everything goes smoothly
github.com/cloudposse/atmos/pull/3474
github.com/cloudposse/atmos/pull/3474
erik11 days ago
@Andriy Knysh (Cloud Posse) more release engineering work github.com/cloudposse/atmos/pull/3500
erik10 days ago
✓ Run Publish verified release (40102300134) completed with 'success'
Release workflow succeeded: <https://github.com/cloudposse/atmos/actions/runs/40102300134>
Published release candidate: v1.233.2-rc.3
Version: 1.233.2-rc.3
Commit: cb23b3f7013ddf64aec8611935a1031c74369577
Release: <https://github.com/cloudposse/atmos/releases/tag/v1.233.2-rc.3>
Workflow: <https://github.com/cloudposse/atmos/actions/runs/40102300134>erik10 days ago
Finally a working RC release
erik10 days ago
✓ Run Publish verified release (40111893170) completed with 'success'
Release workflow succeeded: <https://github.com/cloudposse/atmos/actions/runs/40111893170>
Published release: v1.233.2
Version: 1.233.2
Commit: cb23b3f7013ddf64aec8611935a1031c74369577
Release: <https://github.com/cloudposse/atmos/releases/tag/v1.233.2>
Workflow: <https://github.com/cloudposse/atmos/actions/runs/40111893170>erik10 days ago
@Andriy Knysh (Cloud Posse) small docs only fix github.com/cloudposse/atmos/pull/3472/changes
erik10 days ago
@Andriy Knysh (Cloud Posse) reviewed the documentation for inaccuracies. github.com/cloudposse/atmos/pull/3491/changes
erik10 days ago
@Andriy Knysh (Cloud Posse) improvements to the quality gate process https://github.com/cloudposse/atmos/pull/3476
erik10 days ago
@Andriy Knysh (Cloud Posse) added some coderabbit instructions to suggest refactoring when making changes in internal/exec and our utils pkg. These are legacy packages and should move away from them. github.com/cloudposse/atmos/pull/3521/changes
erik9 days ago
@Andriy Knysh (Cloud Posse) one more quality gate fix github.com/cloudposse/atmos/pull/3539
erik9 days ago
@Andriy Knysh (Cloud Posse) this (2) PR stack is ready - optimizes atmos for CDK deployments.
github.com/cloudposse/atmos/pull/3481
github.com/cloudposse/atmos/pull/3481
erik9 days ago
@Andriy Knysh (Cloud Posse) small k3s emulator fix github.com/cloudposse/atmos/pull/3519
erik9 days ago
@Andriy Knysh (Cloud Posse) small bug fix related
github.com/cloudposse/atmos/pull/3513
--skip handlinggithub.com/cloudposse/atmos/pull/3513
erik9 days ago
@Andriy Knysh (Cloud Posse) small bug fix related to
type: atmos steps and stack handling. github.com/cloudposse/atmos/pull/3518/changeserik9 days ago
@Andriy Knysh (Cloud Posse) small bug fix concerning markdown rendering when there's @ symbols (emails). github.com/cloudposse/atmos/pull/3520
erik9 days ago
@Andriy Knysh (Cloud Posse) improved sops support when multiple vaults share a keyfile
https://github.com/cloudposse/atmos/pull/3522
https://github.com/cloudposse/atmos/pull/3522
erik9 days ago
@Andriy Knysh (Cloud Posse) this adds
github.com/cloudposse/atmos/pull/3454
atmos doctor --fix for legacy *_pattern configuration (migrates them to _template)github.com/cloudposse/atmos/pull/3454
erik8 days ago
@Andriy Knysh (Cloud Posse) this PR stack introduces
atmos stack verbs, that work across all component types and respect --labels and --tag selectors. github.com/cloudposse/atmos/pull/3429erik8 days ago
@Andriy Knysh (Cloud Posse) this fixes an issue with stale quality gates github.com/cloudposse/atmos/pull/3540
erik8 days ago
@Andriy Knysh (Cloud Posse) PR stack for atmos auth plugins is ready and quality gate accepted github.com/cloudposse/atmos/pull/3510
erik8 days ago
@Andriy Knysh (Cloud Posse) atmos auth plugins PR fixed and ready for merge queue again github.com/cloudposse/atmos/pull/3510
erik6 days ago
@Andriy Knysh (Cloud Posse) small fix for atmos plugins github.com/cloudposse/atmos/pull/3554
erik6 days ago
@Andriy Knysh (Cloud Posse) improvements to the release process; github.com/cloudposse/atmos/pull/3509
• pin runners
• more tests for release engineering process
• Add a
• pin runners
• more tests for release engineering process
• Add a
--resume flag so that if atmos release cut is interrupted, the CLI can pick up from where it left off. erik5 days ago
erik3 days ago
@Andriy Knysh (Cloud Posse) another quality gate fix github.com/cloudposse/atmos/pull/3583