#atmos-dev - May 2025

10 messages

Discuss atmos core development (golang). If you want to help out, reach out to @Erik Osterman (Cloud Posse)

Shubham Tholiya
Shubham Tholiyaover 1 year ago
add pager to describe config command by samtholiya · Pull Request #1203 · cloudposse/atmos
We are fine with reviewing this as well
@Erik Osterman (Cloud Posse)
Dan Hansen
Dan Hansenover 1 year ago
It seems like I can't store complex types (like maps) using the GSM Store. It raises ErrValueMustBeString while the other stores allow it by marshalling to/from json.
I think I could implement this, but it'd be a breaking change 🤔
Andriy Knysh (Cloud Posse)
Andriy Knysh (Cloud Posse)over 1 year ago
@Haitham please take a look and fix the folowwing test:
Vinny
Vinnyover 1 year ago
Good morning can someone check https://github.com/cloudposse/atmos/pull/1228 , and https://github.com/cloudposse/atmos/pull/1219 that should be simple to merge
Vinny
Vinnyover 1 year ago
@Dan Miller (tembo) would appreciate if you have time to check again https://github.com/cloudposse/atmos/pull/1180
Shubham Tholiya
Shubham Tholiyaover 1 year ago(edited)
Hi @Dan Miller (tembo) @Ben Smith (Benbentwo)
Can someone of you check my pr's:

Grew a lot because of the time it remained as a pr:
https://github.com/cloudposse/atmos/pull/1174

Pager pr's:
https://github.com/cloudposse/atmos/pull/1203
https://github.com/cloudposse/atmos/pull/1215
https://github.com/cloudposse/atmos/pull/1236 (after update test failed so fixing it now)

no color pr's:
https://github.com/cloudposse/atmos/pull/1227
Charles
Charlesover 1 year ago
Was this PR abandoned? Add Azure Key Vault support for Atmos Stores by jamengual · Pull Request #963 · cloudposse/atmos

@PePe Amengual: I would really like to see key vault support be added to atmos.
PePe Amengual
PePe Amengualover 1 year ago(edited)
is not abandoned, I just did not have time this week to finish it and the bot suspended it
Dan Miller (Cloud Posse)
Dan Miller (Cloud Posse)over 1 year ago
@Vinny, I'm working on another list feature, and I heard that you've also worked on improving the look and feel with list stacks and list components. Do you have a PR I could review?
Shubham Tholiya
Shubham Tholiyaover 1 year ago(edited)
Let us review these two prs in the same order as i mentioned bellow.
note: I stacked the pr, just to avoid rework or waiting for the pr to get merged to main. So 3182 should be merged first then 3221 will automatically target main.

Ofcourse review could be independent.
Feature/dev 3182 add pager to atmos describe affected command by samtholiya · Pull Request #1255 · cloudposse/atmos
Feature/dev 3221 add pager to atmos describe stack command by samtholiya · Pull Request #1265 · cloudposse/atmos
add pager to describe workflow by samtholiya · Pull Request #1266 · cloudposse/atmos