#atmos-dev - February 2025

36 messages

Discuss atmos core development (golang). If you want to help out, reach out to @Erik Osterman (Cloud Posse)

February 2025
Carlos Reyna
Carlos Reynaalmost 2 years ago
Does a small PR like this require a test?
https://github.com/cloudposse/atmos/pull/1004
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)almost 2 years ago
@Michael saw your pr for the spinner! thanks for that. We have the same task so you beat us to it. Looks like you need to regenerate the snapshot for test to pass.

go test ./tests -v -run 'TestCLICommands/atmos_validate_stacks_with_metadata' -regenerate-snapshots 
Carlos Reyna
Carlos Reynaalmost 2 years ago
Greeting! I plan on working DEV-2718 next. I am having a little trouble getting the atmos docs <component> to render as it seems to require a readme. Any insight that might help?
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this is ready for final review https://github.com/cloudposse/atmos/pull/1005
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) ready for final review: https://github.com/cloudposse/atmos/pull/959
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this LGTM, one comment just to add some documentation for zsh configuration.

cc @Michael

https://github.com/cloudposse/atmos/pull/992
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) @Dan Miller (tembo) @Ben Smith (Benbentwo) @Igor Rodionov I think this explains some of the odd behavior with GHA https://github.com/cloudposse/atmos/pull/1028/files


Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) can you advise @Haitham on how to do !repo-root?

https://github.com/cloudposse/atmos/pull/808/files#r1943095714
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) can you review https://github.com/cloudposse/atmos/pull/1024 LGTM
Carlos Reyna
Carlos Reynaover 1 year ago(edited)
I have a questions regarding DEV-2998. I will leave in comments.
Carlos Reyna
Carlos Reynaover 1 year ago
Could I please get a review for PR https://github.com/cloudposse/atmos/pull/1032
shirkevich
shirkevichover 1 year ago
Is it a bug in documentation?

store name is not mentioned

 # Get the `key` from the store of a `component` in the current stack
  !store <component> <key>

  # Get the `key` from the store of a `component` in a different stack
  !store <component> <stack> <key>
...

while in test store name present:
https://github.com/cloudposse/atmos/blob/845aeb56cf9b530457856f64b8641328e8b888d1/internal/exec/yaml_func_store_test.go#L57

		{
			name:         "basic lookup cross-stack",
			input:        "!store redis dev vpc cidr",
			currentStack: "prod",
			expected:     "10.0.0.0/16",
		},

Vinny
Vinnyover 1 year ago
@Andriy Knysh (Cloud Posse) these two is good to review
cc: @Erik Osterman (Cloud Posse)
https://github.com/cloudposse/atmos/pull/979
https://github.com/cloudposse/atmos/pull/994
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago(edited)
@Andriy Knysh (Cloud Posse) I think this is ready for final review: https://github.com/cloudposse/atmos/pull/992
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) if no concerns over this, I think it’s ready for final review and merge https://github.com/cloudposse/atmos/pull/994/files/0d2c9ccdf7bb6a6244ace79d8edb16f00848dc1b#r1948375104
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
Let’s release 992, 979, 994, 1047, 984, 959 together
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
This is ready for final review and merge https://github.com/cloudposse/atmos/pull/1046
Vinny
Vinnyover 1 year ago
good to review @Andriy Knysh (Cloud Posse) @Erik Osterman (Cloud Posse) https://github.com/cloudposse/atmos/pull/979
Andrey Kalmykov
Andrey Kalmykovover 1 year ago(edited)
@Andriy Knysh (Cloud Posse) hi, have fixed the issue with semicolon before the repo name, please kindly take a look if it is better now https://github.com/cloudposse/atmos/pull/984
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this is good for final review: https://github.com/cloudposse/atmos/pull/1052
Vinny
Vinnyover 1 year ago
I see a lot of tests failing in my local when I run the tests, and error on the snapshots, wondering how this is passing in prod
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
I would need to see the failure messages to tell you :-)
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
that happens for you in main?
erik
erikover 1 year ago
@Shubham Tholiya when I complete the following, should --stack be a completion? I understand that the values of --stack are completing, but what about the flag itself?
Vinny
Vinnyover 1 year ago
@Andriy Knysh (Cloud Posse) review ping pls https://github.com/cloudposse/atmos/pull/979
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this is a simple one https://github.com/cloudposse/atmos/pull/1072
Vinny
Vinnyover 1 year ago
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) let’s merge this one liner

https://github.com/cloudposse/atmos/pull/1054
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this is ✅️ and ready to merge. This is for fixing the terraform exit codes.
https://github.com/cloudposse/atmos/pull/1065
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) @Matt Calhoun @Shubham Tholiya
https://github.com/cloudposse/atmos/pull/1078
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) ready for final review https://github.com/cloudposse/atmos/pull/1076
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
Heads up! We've temporarily disabled OCI tests
• https://github.com/cloudposse/atmos/pull/1097
And will restore it in
• https://github.com/cloudposse/atmos/pull/1093
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this is ready for final review. I just left some minor nit picks on logging messages. https://github.com/cloudposse/atmos/pull/1061

Cc @Andrey Kalmykov
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) this is ready for review (and should probably be manually tested as well). One thing we're missing from the documentation, is how the backend path configuration (at least for S3 backend) should be updated when workspaces are disabled. Otherwise all environments will use the same workspace, which will be very bad.



https://github.com/cloudposse/atmos/pull/1073
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago
@Andriy Knysh (Cloud Posse) ready for final review. tests passing
https://github.com/cloudposse/atmos/pull/1096
Erik Osterman (Cloud Posse)
Erik Osterman (Cloud Posse)over 1 year ago