#atmos-dev - December 2024

good for review https://github.com/cloudposse/atmos/pull/815 @Andriy Knysh (Cloud Posse)

Good for review:
• https://github.com/cloudposse/atmos/pull/803
• https://github.com/cloudposse/atmos/pull/807

/github subscribe cloudposse/atmos pulls

✅️ Subscribed to cloudposse/atmos. This channel will receive notifications for pulls

@Haitham should we close https://github.com/cloudposse/atmos/pull/715

Hrmmmmm... @Andriy Knysh (Cloud Posse) looks the brew formulae failed on the latest release.

https://github.com/Homebrew/homebrew-core/actions/runs/12200296819/job/34036272201

https://github.com/cloudposse/atmos/pull/798 @Andriy Knysh (Cloud Posse) good to QA

@Andriy Knysh (Cloud Posse) good to QA
https://github.com/cloudposse/atmos/pull/815

@Vinny please take a look at this:

/github unsubscribe cloudposse/atmos

Unsubscribed from cloudposse/atmos

@Vinny please also resolve the conflicts here https://github.com/cloudposse/atmos/pull/815

Hi Team, this PR is good to review

https://github.com/cloudposse/atmos/pull/828

https://github.com/cloudposse/atmos/pull/815 this is good to review

set the channel topic: Discuss atmos core development (golang). If you want to help out, reach out to @Erik Osterman (Cloud Posse)

@Andriy Knysh (Cloud Posse) so here https://linear.app/cloudposse/issue/DEV-2785/running-atmos-workflow-incorrectly-produces-useless-usage I noticed running things like atmos workflow list throws an error because theres no stacks path
so I was thinking in something more user friendly like

Workflows directory not found at '/Users/viniciuscardoso/Developer/atmos/stacks/workflows'

To set up workflows:
1. Create a workflows directory at '/Users/viniciuscardoso/Developer/atmos/stacks/workflows'
2. Add your workflow YAML files in this directory
3. Configure the workflows path in your atmos.yaml:

   workflows:
     basePath: stacks/workflows

For more information, visit: <https://atmos.tools/cli/commands/workflow>

of course I am going to remove those uselless error msgs, but I am also think in ways to improve that
btw we can improve this output using charmbracelet

I updated this https://linear.app/cloudposse/issue/DEV-2801/implement-atmos-list-workflows

It's not urgent, but can I get a review on this PR that implements a basic pager for the atmos docs command?
https://github.com/cloudposse/atmos/pull/848

@Andriy Knysh (Cloud Posse) hi, have pushed the PR, would appreciate if you could please take a look when you have a minute. https://github.com/cloudposse/atmos/pull/844 @Erik Osterman (Cloud Posse) FYI

@Andriy Knysh (Cloud Posse) cannot reproduce the problem you raised: https://github.com/cloudposse/atmos/pull/768

We also added a test for this that is passing. Can you try again?

https://linear.app/cloudposse/issue/DEV-2322/help-not-showing-for-custom-commands-when-using-the-nested-command
Do we know who raised this ticket.
We would require reproduction steps.

Whenever someone creates a bug ticket please mention the steps, This avoids back and forth.
1. Steps
2. Screenshots
3. Expected behavior
These 3 are a must in a bug ticket

@Andriy Knysh (Cloud Posse) do you know if there are any of these unsupported commands we actually support?

@Shubham Tholiya is helping us clean up atmos terraform --help

Hey anyone found this issue
the long description for terraform does not get printed.
i added .Long in template and now every command shows description twice for all other commands except terraform 😅

@Andriy Knysh (Cloud Posse) hi, if it wouldn't be too much trouble, could you please take a look when you have a minute? https://github.com/cloudposse/atmos/pull/866

main is currently broken. It was accidentally broken in https://github.com/cloudposse/atmos/pull/856, which broke Windows support because we had no tests run on Windows.

We merged https://github.com/cloudposse/atmos/pull/875, which adds windows & macos tests, so until we resolve the breaking change in 856, windows tests are failing.

@Andriy Knysh (Cloud Posse) , @Haitham helped me fix the tests: https://github.com/cloudposse/atmos/pull/887

@Vinny would be great to get your glamour inprovements ready. I think we need it to finish the work @Shubham Tholiya is doing on the terraform help pages.

Just putting things here so that we do not re work everytime on help:

We have a pr: https://github.com/cloudposse/atmos/pull/857

This pr will try to depricate help.go in favour of supporting native cobra help.

Please do not add/edit help.go .
If required contribute to the pr above

We would have followup pr's ofcourse that i will update as and when required.

Just wanted to understand this
I observe that viper and cobra are not binded as per recommendations
While i do understand why it might have been that way.
I would recommend let us change that so that we remove a lot of code

Wdyt @Andriy Knysh (Cloud Posse)
cc: @Erik Osterman (Cloud Posse)

@Haitham please check https://github.com/cloudposse/atmos/issues/832#issuecomment-2565902028

yes windows has issue when search for files I will review

Hey team this is an important observation
please check my comment: https://github.com/cloudposse/atmos/pull/896/files#r1899825937
@Andriy Knysh (Cloud Posse) or @Erik Osterman (Cloud Posse) might know if there are specific reasons for this (if they are aware of this)
Currently i stand on the side that this should not work the way it is. Unless someone convinces me of the reasons these special file configs exists.